Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(73)

Unified Diff: ios/web/web_state/ui/crw_web_controller.mm

Issue 2910453002: Use ui::PAGE_TRANSITION_RELOAD transition for web page reload. (Closed)
Patch Set: Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ios/web/web_state/navigation_callbacks_inttest.mm ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ios/web/web_state/ui/crw_web_controller.mm
diff --git a/ios/web/web_state/ui/crw_web_controller.mm b/ios/web/web_state/ui/crw_web_controller.mm
index c51d5bf313e9dfbcb30dd75a5f69d7bfe8893670..a169d6d51fa480e7964f27bab156fc0bb6e14aed 100644
--- a/ios/web/web_state/ui/crw_web_controller.mm
+++ b/ios/web/web_state/ui/crw_web_controller.mm
@@ -2052,10 +2052,8 @@ registerLoadRequestForURL:(const GURL&)requestURL
[transientItem->GetHttpRequestHeaders() copy]);
[self loadWithParams:reloadParams];
} else {
- // As with back and forward navigation, load the URL manually instead of
- // using the web view's reload. This ensures state processing and delegate
Eugene But (OOO till 7-30) 2017/05/25 17:10:08 This is not true for WKWebView. |loadCurrentURL| w
- // calls are consistent.
- // TODO(eugenebut): revisit this for WKWebView.
+ self.currentNavItem->SetTransitionType(
+ ui::PageTransition::PAGE_TRANSITION_RELOAD);
kkhorimoto 2017/05/26 17:32:42 Is this what's done in content// as well? It seem
Eugene But (OOO till 7-30) 2017/05/26 17:48:32 I'm pretty sure they reset navigation to reload wh
[self loadCurrentURL];
}
}
« no previous file with comments | « ios/web/web_state/navigation_callbacks_inttest.mm ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698