Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(39)

Issue 2903883002: Added NavigationContext::IsPost. (Closed)

Created:
3 years, 7 months ago by Eugene But (OOO till 7-30)
Modified:
3 years, 7 months ago
Reviewers:
kkhorimoto
CC:
chromium-reviews, ios-reviews_chromium.org, ios-reviews+web_chromium.org, liaoyuke+watch_chromium.org, Eugene But (OOO till 7-30), huangml+watch_chromium.org, baxley+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Added NavigationContext::IsPost. This new API will allow removing -[CRWNativeContentProvider controllerForURL:withError:isPost:] callback and replacing it with general purpose WebStateObserver::DidFinishNavigation that takes NavigationContext. BUG=725241 Review-Url: https://codereview.chromium.org/2903883002 Cr-Commit-Position: refs/heads/master@{#475177} Committed: https://chromium.googlesource.com/chromium/src/+/e97865b7bccd9e278a2902b4ae3b0feac0b088c7

Patch Set 1 #

Patch Set 2 : Self review #

Patch Set 3 : Rebased #

Patch Set 4 : Self review #

Unified diffs Side-by-side diffs Delta from patch set Stats (+222 lines, -4 lines) Patch
M ios/web/public/web_state/navigation_context.h View 1 2 3 1 chunk +9 lines, -0 lines 0 comments Download
M ios/web/test/web_int_test.h View 1 chunk +3 lines, -0 lines 0 comments Download
M ios/web/test/web_int_test.mm View 1 chunk +10 lines, -4 lines 0 comments Download
M ios/web/web_state/navigation_callbacks_inttest.mm View 1 2 9 chunks +175 lines, -0 lines 0 comments Download
M ios/web/web_state/navigation_context_impl.h View 2 chunks +3 lines, -0 lines 0 comments Download
M ios/web/web_state/navigation_context_impl.mm View 2 chunks +8 lines, -0 lines 0 comments Download
M ios/web/web_state/navigation_context_impl_unittest.mm View 1 2 chunks +11 lines, -0 lines 0 comments Download
M ios/web/web_state/ui/crw_web_controller.mm View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M ios/web/web_state/web_state_impl_unittest.mm View 1 2 chunks +2 lines, -0 lines 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 12 (8 generated)
Eugene But (OOO till 7-30)
3 years, 7 months ago (2017-05-25 20:58:21 UTC) #6
kkhorimoto
lgtm!
3 years, 7 months ago (2017-05-25 21:07:10 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2903883002/60001
3 years, 7 months ago (2017-05-26 22:45:01 UTC) #9
commit-bot: I haz the power
3 years, 7 months ago (2017-05-26 23:16:46 UTC) #12
Message was sent while issue was closed.
Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/e97865b7bccd9e278a2902b4ae3b...

Powered by Google App Engine
This is Rietveld 408576698