Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(318)

Issue 2910123002: Make TextOrientation an enum class. (Closed)

Created:
3 years, 6 months ago by nainar
Modified:
3 years, 6 months ago
Reviewers:
dstockwell, shend, rune
CC:
darktears, apavlov+blink_chromium.org, blink-reviews, blink-reviews-css, blink-reviews-style_chromium.org, chromium-reviews, dglazkov+blink, rwlbuis
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Make TextOrientation an enum class. This patch makes TextOrientation an enum class for type safety. BUG=684966 Review-Url: https://codereview.chromium.org/2910123002 Cr-Commit-Position: refs/heads/master@{#475462} Committed: https://chromium.googlesource.com/chromium/src/+/c727599592c604933f4a437852e045c912b9d517

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -20 lines) Patch
M third_party/WebKit/Source/core/css/CSSPrimitiveValueMappings.h View 2 chunks +7 lines, -7 lines 0 comments Download
M third_party/WebKit/Source/core/css/CSSProperties.json5 View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/css/ComputedStyleCSSValueMapping.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/css/resolver/FontBuilder.cpp View 1 chunk +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/style/ComputedStyle.h View 2 chunks +5 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/style/ComputedStyleConstants.h View 1 chunk +1 line, -5 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 16 (10 generated)
nainar
3 years, 6 months ago (2017-05-30 03:43:29 UTC) #3
shend
lgtm
3 years, 6 months ago (2017-05-30 05:01:21 UTC) #5
nainar
3 years, 6 months ago (2017-05-30 05:01:56 UTC) #7
rune
rs lgtm
3 years, 6 months ago (2017-05-30 08:07:42 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2910123002/1
3 years, 6 months ago (2017-05-30 08:11:18 UTC) #13
commit-bot: I haz the power
3 years, 6 months ago (2017-05-30 08:15:27 UTC) #16
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/c727599592c604933f4a437852e0...

Powered by Google App Engine
This is Rietveld 408576698