Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(334)

Unified Diff: third_party/WebKit/Source/core/style/ComputedStyle.h

Issue 2910123002: Make TextOrientation an enum class. (Closed)
Patch Set: Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/style/ComputedStyle.h
diff --git a/third_party/WebKit/Source/core/style/ComputedStyle.h b/third_party/WebKit/Source/core/style/ComputedStyle.h
index 9823d00a0dcc8a64af401490b4aef5d22413a90f..884e5997c3252cff4f524a7b2e9066752d578691 100644
--- a/third_party/WebKit/Source/core/style/ComputedStyle.h
+++ b/third_party/WebKit/Source/core/style/ComputedStyle.h
@@ -1757,7 +1757,7 @@ class CORE_EXPORT ComputedStyle : public ComputedStyleBase<ComputedStyle>,
// text-orientation (aka -webkit-text-orientation, -epub-text-orientation)
static TextOrientation InitialTextOrientation() {
- return kTextOrientationMixed;
+ return TextOrientation::kMixed;
}
TextOrientation GetTextOrientation() const {
return static_cast<TextOrientation>(
@@ -3781,10 +3781,12 @@ inline bool ComputedStyle::IsSharable() const {
inline bool ComputedStyle::SetTextOrientation(
TextOrientation text_orientation) {
- if (compareEqual(rare_inherited_data_->text_orientation_, text_orientation))
+ if (compareEqual(rare_inherited_data_->text_orientation_,
+ static_cast<unsigned>(text_orientation)))
return false;
- rare_inherited_data_.Access()->text_orientation_ = text_orientation;
+ rare_inherited_data_.Access()->text_orientation_ =
+ static_cast<unsigned>(text_orientation);
return true;
}

Powered by Google App Engine
This is Rietveld 408576698