Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(661)

Unified Diff: third_party/WebKit/Source/core/css/CSSPrimitiveValueMappings.h

Issue 2910123002: Make TextOrientation an enum class. (Closed)
Patch Set: Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/css/CSSProperties.json5 » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/core/css/CSSPrimitiveValueMappings.h
diff --git a/third_party/WebKit/Source/core/css/CSSPrimitiveValueMappings.h b/third_party/WebKit/Source/core/css/CSSPrimitiveValueMappings.h
index 91e2a87d743525075cc1a35a836b737349a6c664..04cd1a1bb636cb66b0ebc91339f9c97db815dc3c 100644
--- a/third_party/WebKit/Source/core/css/CSSPrimitiveValueMappings.h
+++ b/third_party/WebKit/Source/core/css/CSSPrimitiveValueMappings.h
@@ -1639,13 +1639,13 @@ template <>
inline CSSIdentifierValue::CSSIdentifierValue(TextOrientation e)
: CSSValue(kIdentifierClass) {
switch (e) {
- case kTextOrientationSideways:
+ case TextOrientation::kSideways:
value_id_ = CSSValueSideways;
break;
- case kTextOrientationMixed:
+ case TextOrientation::kMixed:
value_id_ = CSSValueMixed;
break;
- case kTextOrientationUpright:
+ case TextOrientation::kUpright:
value_id_ = CSSValueUpright;
break;
}
@@ -1656,18 +1656,18 @@ inline TextOrientation CSSIdentifierValue::ConvertTo() const {
switch (value_id_) {
case CSSValueSideways:
case CSSValueSidewaysRight:
- return kTextOrientationSideways;
+ return TextOrientation::kSideways;
case CSSValueMixed:
case CSSValueVerticalRight: // -webkit-text-orientation
- return kTextOrientationMixed;
+ return TextOrientation::kMixed;
case CSSValueUpright:
- return kTextOrientationUpright;
+ return TextOrientation::kUpright;
default:
break;
}
NOTREACHED();
- return kTextOrientationMixed;
+ return TextOrientation::kMixed;
}
template <>
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/css/CSSProperties.json5 » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698