Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(591)

Issue 2913723002: Generate enum/getters/setters/mappings for text-orientation. (Closed)

Created:
1 year ago by nainar
Modified:
1 year ago
Reviewers:
meade_UTC10, shend
CC:
darktears, apavlov+blink_chromium.org, blink-reviews, blink-reviews-css, blink-reviews-style_chromium.org, chromium-reviews, dglazkov+blink, rwlbuis
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Generate enum/getters/setters/mappings for text-orientation. Currently, the text-orientation property is a 'storage_only' field, so it has no generated public getters/setters. This patch changes it to a 'keyword' field so that its getters/setters can be generated as well. We also generate the ETextOrientation enum and use the generated CSSValueID <-> ETextOrientation mappings. Diff: https://gist.github.com/nainar/257662e77043a84cf3def269576e534a/revisions BUG=628043 Review-Url: https://codereview.chromium.org/2913723002 Cr-Commit-Position: refs/heads/master@{#475880} Committed: https://chromium.googlesource.com/chromium/src/+/f3833029711d581ebebedaeaf3412b2463c857ea

Patch Set 1 #

Total comments: 4

Patch Set 2 : shend@ suggestions #

Patch Set 3 : Rebase #

Messages

Total messages: 29 (19 generated)
nainar
shend@, This crashes in case you pass a differing value to the three accepted which ...
1 year ago (2017-05-30 09:05:09 UTC) #7
shend
https://codereview.chromium.org/2913723002/diff/1/third_party/WebKit/Source/core/css/CSSPrimitiveValueMappings.h File third_party/WebKit/Source/core/css/CSSPrimitiveValueMappings.h (left): https://codereview.chromium.org/2913723002/diff/1/third_party/WebKit/Source/core/css/CSSPrimitiveValueMappings.h#oldcode1625 third_party/WebKit/Source/core/css/CSSPrimitiveValueMappings.h:1625: case CSSValueSidewaysRight: Special case here, gotta override it in ...
1 year ago (2017-05-30 20:48:43 UTC) #8
nainar
shend@, PTAL? Thanks! https://codereview.chromium.org/2913723002/diff/1/third_party/WebKit/Source/core/css/CSSPrimitiveValueMappings.h File third_party/WebKit/Source/core/css/CSSPrimitiveValueMappings.h (left): https://codereview.chromium.org/2913723002/diff/1/third_party/WebKit/Source/core/css/CSSPrimitiveValueMappings.h#oldcode1625 third_party/WebKit/Source/core/css/CSSPrimitiveValueMappings.h:1625: case CSSValueSidewaysRight: Done. https://codereview.chromium.org/2913723002/diff/1/third_party/WebKit/Source/core/css/CSSPrimitiveValueMappings.h#oldcode1628 third_party/WebKit/Source/core/css/CSSPrimitiveValueMappings.h:1628: case ...
1 year ago (2017-05-31 03:59:57 UTC) #11
shend
lgtm
1 year ago (2017-05-31 04:28:33 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2913723002/20001
1 year ago (2017-05-31 05:22:19 UTC) #16
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/468110)
1 year ago (2017-05-31 05:29:31 UTC) #18
nainar
meade@, PTAL? Thanks!
1 year ago (2017-05-31 05:31:20 UTC) #20
meade_UTC10
lgtm looks like you need to rebase, linux_chromium_rel_ng had a patch error :/
1 year ago (2017-05-31 06:02:46 UTC) #21
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2913723002/40001
1 year ago (2017-05-31 07:46:56 UTC) #26
commit-bot: I haz the power
1 year ago (2017-05-31 11:52:14 UTC) #29
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/f3833029711d581ebebedaeaf341...

Powered by Google App Engine
This is Rietveld 408576698