Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(9)

Issue 2908883002: [Extensions Bindings] Remove some modules with native bindings (Closed)

Created:
3 years, 6 months ago by Devlin
Modified:
3 years, 6 months ago
Reviewers:
lazyboy, jbroman
CC:
chromium-apps-reviews_chromium.org, chromium-reviews, extensions-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[Extensions Bindings] Remove some modules with native bindings Native bindings should replace many of the core modules used in extension APIs. Don't include some of these when native bindings are enabled. Update custom bindings that are exercised in native binding tests to behavior properly with either JS or native bindings. BUG=653596 Review-Url: https://codereview.chromium.org/2908883002 Cr-Commit-Position: refs/heads/master@{#476521} Committed: https://chromium.googlesource.com/chromium/src/+/9e5faa7dab8cb4257200a34d14dc58aab119f634

Patch Set 1 #

Patch Set 2 : . #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+62 lines, -37 lines) Patch
M chrome/renderer/extensions/chrome_extensions_dispatcher_delegate.cc View 2 chunks +8 lines, -6 lines 0 comments Download
M chrome/renderer/resources/extensions/cast_streaming_receiver_session_custom_bindings.js View 1 chunk +7 lines, -4 lines 0 comments Download
M chrome/renderer/resources/extensions/cast_streaming_rtp_stream_custom_bindings.js View 2 chunks +4 lines, -2 lines 0 comments Download
M chrome/renderer/resources/extensions/cast_streaming_session_custom_bindings.js View 2 chunks +4 lines, -2 lines 0 comments Download
M chrome/renderer/resources/extensions/cast_streaming_udp_transport_custom_bindings.js View 2 chunks +4 lines, -2 lines 0 comments Download
M chrome/renderer/resources/extensions/page_action_custom_bindings.js View 1 1 chunk +10 lines, -7 lines 0 comments Download
M chrome/renderer/resources/extensions/web_view/chrome_web_view.js View 1 chunk +3 lines, -1 line 0 comments Download
M chrome/renderer/resources/extensions/web_view/chrome_web_view_internal_custom_bindings.js View 2 chunks +4 lines, -3 lines 0 comments Download
M extensions/renderer/dispatcher.cc View 1 chunk +7 lines, -4 lines 0 comments Download
M extensions/renderer/resources/extension_custom_bindings.js View 2 chunks +3 lines, -2 lines 0 comments Download
M extensions/renderer/resources/guest_view/web_view/web_view_action_requests.js View 1 chunk +3 lines, -1 line 0 comments Download
M extensions/renderer/resources/guest_view/web_view/web_view_internal.js View 1 chunk +5 lines, -3 lines 1 comment Download

Dependent Patchsets:

Messages

Total messages: 17 (12 generated)
Devlin
Heya folks, mind taking a quick look? https://codereview.chromium.org/2908883002/diff/20001/extensions/renderer/resources/guest_view/web_view/web_view_internal.js File extensions/renderer/resources/guest_view/web_view/web_view_internal.js (right): https://codereview.chromium.org/2908883002/diff/20001/extensions/renderer/resources/guest_view/web_view/web_view_internal.js#newcode6 extensions/renderer/resources/guest_view/web_view/web_view_internal.js:6: exports.$set( We ...
3 years, 6 months ago (2017-05-30 22:36:58 UTC) #10
jbroman
lgtm
3 years, 6 months ago (2017-05-31 20:09:21 UTC) #11
lazyboy
lgtm
3 years, 6 months ago (2017-06-01 22:09:04 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2908883002/20001
3 years, 6 months ago (2017-06-02 01:15:28 UTC) #14
commit-bot: I haz the power
3 years, 6 months ago (2017-06-02 02:08:48 UTC) #17
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/9e5faa7dab8cb4257200a34d14dc...

Powered by Google App Engine
This is Rietveld 408576698