Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1540)

Unified Diff: chrome/renderer/extensions/chrome_extensions_dispatcher_delegate.cc

Issue 2908883002: [Extensions Bindings] Remove some modules with native bindings (Closed)
Patch Set: . Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/renderer/extensions/chrome_extensions_dispatcher_delegate.cc
diff --git a/chrome/renderer/extensions/chrome_extensions_dispatcher_delegate.cc b/chrome/renderer/extensions/chrome_extensions_dispatcher_delegate.cc
index 06cc9d02436f40787b83767c4014498983c74549..990fa4a559b9178b2583ca46c928bd9218e66d83 100644
--- a/chrome/renderer/extensions/chrome_extensions_dispatcher_delegate.cc
+++ b/chrome/renderer/extensions/chrome_extensions_dispatcher_delegate.cc
@@ -253,11 +253,6 @@ void ChromeExtensionsDispatcherDelegate::PopulateSourceMap(
IDR_WEBRTC_DESKTOP_CAPTURE_PRIVATE_CUSTOM_BINDINGS_JS);
source_map->RegisterSource("webstore", IDR_WEBSTORE_CUSTOM_BINDINGS_JS);
- // Custom types sources.
- source_map->RegisterSource("ChromeSetting", IDR_CHROME_SETTING_JS);
- source_map->RegisterSource("ContentSetting", IDR_CONTENT_SETTING_JS);
- source_map->RegisterSource("ChromeDirectSetting",
- IDR_CHROME_DIRECT_SETTING_JS);
// Platform app sources that are not API-specific..
source_map->RegisterSource("chromeWebViewInternal",
@@ -283,8 +278,15 @@ void ChromeExtensionsDispatcherDelegate::PopulateSourceMap(
source_map->RegisterSource("url/mojo/url.mojom", IDR_MOJO_URL_MOJOM_JS);
// These bindings are unnecessary with native bindings enabled.
- if (!extensions::FeatureSwitch::native_crx_bindings()->IsEnabled())
+ if (!extensions::FeatureSwitch::native_crx_bindings()->IsEnabled()) {
source_map->RegisterSource("app", IDR_APP_CUSTOM_BINDINGS_JS);
+
+ // Custom types sources.
+ source_map->RegisterSource("ChromeSetting", IDR_CHROME_SETTING_JS);
+ source_map->RegisterSource("ContentSetting", IDR_CONTENT_SETTING_JS);
+ source_map->RegisterSource("ChromeDirectSetting",
+ IDR_CHROME_DIRECT_SETTING_JS);
+ }
}
void ChromeExtensionsDispatcherDelegate::RequireAdditionalModules(

Powered by Google App Engine
This is Rietveld 408576698