chrome/renderer/resources/extensions/web_view/chrome_web_view_internal_custom_bindings.js - Issue 2908883002: [Extensions Bindings] Remove some modules with native bindings

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/renderer/resources/extensions/web_view/chrome_web_view_internal_custom_bindings.js

Issue 2908883002: [Extensions Bindings] Remove some modules with native bindings (Closed)

Patch Set: . Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/renderer/resources/extensions/web_view/chrome_web_view.js ('k') | extensions/renderer/dispatcher.cc » ('j') | extensions/renderer/resources/guest_view/web_view/web_view_internal.js » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/renderer/resources/extensions/web_view/chrome_web_view_internal_custom_bindings.js

diff --git a/chrome/renderer/resources/extensions/web_view/chrome_web_view_internal_custom_bindings.js b/chrome/renderer/resources/extensions/web_view/chrome_web_view_internal_custom_bindings.js

index 79bf906fb8d6a1c4f34d389b38eb71028ce5932e..3cc2e3d954d76629659f1d13006a4bbf763665ca 100644

--- a/chrome/renderer/resources/extensions/web_view/chrome_web_view_internal_custom_bindings.js

+++ b/chrome/renderer/resources/extensions/web_view/chrome_web_view_internal_custom_bindings.js

@@ -2,7 +2,8 @@

// Use of this source code is governed by a BSD-style license that can be

// found in the LICENSE file.

-var binding = require('binding').Binding.create('chromeWebViewInternal');

+var binding = apiBridge ||

+ require('binding').Binding.create('chromeWebViewInternal');

var contextMenusHandlers = require('contextMenusHandlers');

binding.registerCustomHook(function(bindingsAPI) {

@@ -21,7 +22,7 @@ binding.registerCustomHook(function(bindingsAPI) {

apiFunctions.setHandleRequest(

'contextMenusRemoveAll', handlers.requestHandlers.removeAll);

});

-exports.$set('ChromeWebView', binding.generate());

+if (!apiBridge)

+ exports.$set('ChromeWebView', binding.generate());