[Extensions Bindings] Don't allow `event` module with native bindings

[Extensions Bindings] Don't allow `event` module with native bindings

With native bindings, events should be constructed with the through the
native hooks, rather than the JS event implementation. Don't include the
event JS module when native bindings are enabled.

This requires updating bindings code used in native bindings browser
tests that currently relies on the event module, most notably webviews.
Provide the native functionality to create a declarative event through
the JS hooks, and include a webview id with declarative events.

Also avoid subclassing the event class in the JS custom hooks for both
native and JS-based bindings.

Finally, remove some stale require()s where they were unnecessary.

BUG=653596
Review-Url: https://codereview.chromium.org/2912883004
Cr-Commit-Position: refs/heads/master@{#479183}
Committed: https://chromium.googlesource.com/chromium/src/+/3e46aa6ced2554cd07a7cc9aad1ec98b384dff07

[Devlin, 2017-05-31 01:52:15]

The CQ bit was checked by rdevlin.cronin@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-31 01:53:07]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-31 02:28:30]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-31 02:28:31]

Dry run: Try jobs failed on following builders:
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Devlin, 2017-05-31 15:37:03]

The CQ bit was checked by rdevlin.cronin@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-31 15:37:24]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-31 16:23:30]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-31 16:23:32]

Dry run: This issue passed the CQ dry run.

[Devlin, 2017-06-02 21:20:48]

Description was changed from

==========
blacklistevent
==========

to

==========
[Extenisons Bindings] Don't allow `event` module with native bindings

With native bindings, events should be constructed with the through the
native hooks, rather than the JS event implementation. Don't include the
event JS module when native bindings are enabled.

This requires updating bindings code used in native bindings browser
tests that currently relies on the event module, most notably webviews.
Provide the native functionality to create a declarative event through
the JS hooks, and include a webview id with declarative events.

Also avoid subclassing the event class in the JS custom hooks for both
native and JS-based bindings.

Finally, remove some stale require()s where they were unnecessary.

BUG=653596
==========

[Devlin, 2017-06-03 01:10:18]

Patchset #2 (id:20001) has been deleted

[Devlin, 2017-06-03 01:10:25]

Patchset #1 (id:1) has been deleted

[Devlin, 2017-06-03 01:10:40]

rdevlin.cronin@chromium.org changed reviewers:
+ jbroman@chromium.org, lazyboy@chromium.org

[Devlin, 2017-06-03 01:10:41]

Heya folks, mind taking a look?

[Devlin, 2017-06-09 20:26:52]

friendly ping :)

[jbroman, 2017-06-12 15:09:33]

Description was changed from

==========
[Extenisons Bindings] Don't allow `event` module with native bindings

With native bindings, events should be constructed with the through the
native hooks, rather than the JS event implementation. Don't include the
event JS module when native bindings are enabled.

This requires updating bindings code used in native bindings browser
tests that currently relies on the event module, most notably webviews.
Provide the native functionality to create a declarative event through
the JS hooks, and include a webview id with declarative events.

Also avoid subclassing the event class in the JS custom hooks for both
native and JS-based bindings.

Finally, remove some stale require()s where they were unnecessary.

BUG=653596
==========

to

==========
[Extensions Bindings] Don't allow `event` module with native bindings

With native bindings, events should be constructed with the through the
native hooks, rather than the JS event implementation. Don't include the
event JS module when native bindings are enabled.

This requires updating bindings code used in native bindings browser
tests that currently relies on the event module, most notably webviews.
Provide the native functionality to create a declarative event through
the JS hooks, and include a webview id with declarative events.

Also avoid subclassing the event class in the JS custom hooks for both
native and JS-based bindings.

Finally, remove some stale require()s where they were unnecessary.

BUG=653596
==========

[jbroman, 2017-06-12 15:09:49]

lgtm

Sorry for missing this.

https://codereview.chromium.org/2912883004/diff/40001/extensions/renderer/mod...
File extensions/renderer/module_system.cc (right):

https://codereview.chromium.org/2912883004/diff/40001/extensions/renderer/mod...
extensions/renderer/module_system.cc:848: 
super-nit: accidental change?

https://codereview.chromium.org/2912883004/diff/40001/extensions/renderer/res...
File extensions/renderer/resources/app_runtime_custom_bindings.js (right):

https://codereview.chromium.org/2912883004/diff/40001/extensions/renderer/res...
extensions/renderer/resources/app_runtime_custom_bindings.js:14:
bindingUtil.registerEventArgumentMassager.bind(bindingUtil) :
Do we need to use $Function.bind here?

[Devlin, 2017-06-12 20:30:14]

https://codereview.chromium.org/2912883004/diff/40001/extensions/renderer/mod...
File extensions/renderer/module_system.cc (right):

https://codereview.chromium.org/2912883004/diff/40001/extensions/renderer/mod...
extensions/renderer/module_system.cc:848: 
On 2017/06/12 15:09:48, jbroman wrote:
> super-nit: accidental change?

Yep!  Removed.

https://codereview.chromium.org/2912883004/diff/40001/extensions/renderer/res...
File extensions/renderer/resources/app_runtime_custom_bindings.js (right):

https://codereview.chromium.org/2912883004/diff/40001/extensions/renderer/res...
extensions/renderer/resources/app_runtime_custom_bindings.js:14:
bindingUtil.registerEventArgumentMassager.bind(bindingUtil) :
On 2017/06/12 15:09:49, jbroman wrote:
> Do we need to use $Function.bind here?

Done.

[Devlin, 2017-06-12 20:30:24]

The CQ bit was checked by rdevlin.cronin@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-12 20:30:55]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-12 21:44:46]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-12 21:44:48]

Dry run: This issue passed the CQ dry run.

[lazyboy, 2017-06-13 17:46:01]

lgtm

https://codereview.chromium.org/2912883004/diff/60001/chrome/renderer/resourc...
File chrome/renderer/resources/extensions/web_view/chrome_web_view.js (right):

https://codereview.chromium.org/2912883004/diff/60001/chrome/renderer/resourc...
chrome/renderer/resources/extensions/web_view/chrome_web_view.js:42: function
getContextMenusOnClickedEvent(webViewInstanceId,
nit: s/get/create

https://codereview.chromium.org/2912883004/diff/60001/extensions/renderer/api...
File extensions/renderer/api_binding_js_util.h (right):

https://codereview.chromium.org/2912883004/diff/60001/extensions/renderer/api...
extensions/renderer/api_binding_js_util.h:71: int webview_id);
nit: webview_instance_id

https://codereview.chromium.org/2912883004/diff/60001/extensions/renderer/dec...
File extensions/renderer/declarative_event.h (right):

https://codereview.chromium.org/2912883004/diff/60001/extensions/renderer/dec...
extensions/renderer/declarative_event.h:56: int webview_instance_id_;
const;

[Devlin, 2017-06-13 21:00:13]

The CQ bit was checked by rdevlin.cronin@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-13 21:01:01]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-13 22:19:47]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-13 22:19:48]

Dry run: This issue passed the CQ dry run.

[Devlin, 2017-06-13 22:30:53]

https://codereview.chromium.org/2912883004/diff/60001/chrome/renderer/resourc...
File chrome/renderer/resources/extensions/web_view/chrome_web_view.js (right):

https://codereview.chromium.org/2912883004/diff/60001/chrome/renderer/resourc...
chrome/renderer/resources/extensions/web_view/chrome_web_view.js:42: function
getContextMenusOnClickedEvent(webViewInstanceId,
On 2017/06/13 17:46:00, lazyboy wrote:
> nit: s/get/create

Done.

https://codereview.chromium.org/2912883004/diff/60001/extensions/renderer/api...
File extensions/renderer/api_binding_js_util.h (right):

https://codereview.chromium.org/2912883004/diff/60001/extensions/renderer/api...
extensions/renderer/api_binding_js_util.h:71: int webview_id);
On 2017/06/13 17:46:00, lazyboy wrote:
> nit: webview_instance_id

Done.

https://codereview.chromium.org/2912883004/diff/60001/extensions/renderer/dec...
File extensions/renderer/declarative_event.h (right):

https://codereview.chromium.org/2912883004/diff/60001/extensions/renderer/dec...
extensions/renderer/declarative_event.h:56: int webview_instance_id_;
On 2017/06/13 17:46:01, lazyboy wrote:
> const;

Done.

[Devlin, 2017-06-13 22:30:58]

The CQ bit was checked by rdevlin.cronin@chromium.org

[Devlin, 2017-06-13 22:30:58]

The patchset sent to the CQ was uploaded after l-g-t-m from
jbroman@chromium.org, lazyboy@chromium.org
Link to the patchset: https://codereview.chromium.org/2912883004/#ps80001
(title: "lazyboy's")

[commit-bot: I haz the power, 2017-06-13 22:31:52]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-13 22:38:27]

CQ is committing da patch.

Bot data: {"patchset_id": 80001, "attempt_start_ts": 1497393058333510,
"parent_rev": "c8ccba8b415fa20f5ded85c58a100cfb3cdda4c4", "commit_rev":
"3e46aa6ced2554cd07a7cc9aad1ec98b384dff07"}

[commit-bot: I haz the power, 2017-06-13 22:38:41]

Description was changed from

==========
[Extensions Bindings] Don't allow `event` module with native bindings

With native bindings, events should be constructed with the through the
native hooks, rather than the JS event implementation. Don't include the
event JS module when native bindings are enabled.

This requires updating bindings code used in native bindings browser
tests that currently relies on the event module, most notably webviews.
Provide the native functionality to create a declarative event through
the JS hooks, and include a webview id with declarative events.

Also avoid subclassing the event class in the JS custom hooks for both
native and JS-based bindings.

Finally, remove some stale require()s where they were unnecessary.

BUG=653596
==========

to

==========
[Extensions Bindings] Don't allow `event` module with native bindings

With native bindings, events should be constructed with the through the
native hooks, rather than the JS event implementation. Don't include the
event JS module when native bindings are enabled.

This requires updating bindings code used in native bindings browser
tests that currently relies on the event module, most notably webviews.
Provide the native functionality to create a declarative event through
the JS hooks, and include a webview id with declarative events.

Also avoid subclassing the event class in the JS custom hooks for both
native and JS-based bindings.

Finally, remove some stale require()s where they were unnecessary.

BUG=653596

Review-Url: https://codereview.chromium.org/2912883004
Cr-Commit-Position: refs/heads/master@{#479183}
Committed:
https://chromium.googlesource.com/chromium/src/+/3e46aa6ced2554cd07a7cc9aad1e...
==========

[commit-bot: I haz the power, 2017-06-13 22:38:43]

Committed patchset #3 (id:80001) as
https://chromium.googlesource.com/chromium/src/+/3e46aa6ced2554cd07a7cc9aad1e...