Add CompositionMarker (subclass of DocumentMarker)
This CL moves the Composition marker-specific functionality of DocumentMarker
into a new CompositionMarker subclass (similar to TextMatchMarker). I will do
the same for Spelling and Grammar markers in future CLs.
BUG=707867
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Review-Url: https://codereview.chromium.org/2908643002
Cr-Commit-Position: refs/heads/master@{#476220}
Committed: https://chromium.googlesource.com/chromium/src/+/2546cdae560f745b5ee91856244bf12f36729e44
Description was changed from ========== Add CompositionMarker (subclass of DocumentMarker) This CL moves the Composition ...
3 years, 7 months ago
(2017-05-25 23:11:41 UTC)
#1
Description was changed from
==========
Add CompositionMarker (subclass of DocumentMarker)
This CL moves the Composition marker-specific functionality of DocumentMarker
into a new CompositionMarker subclass (similar to TextMatchMarker). I will do
the same for Spelling and Grammar markers in future CLs.
BUG=707867
==========
to
==========
Add CompositionMarker (subclass of DocumentMarker)
This CL moves the Composition marker-specific functionality of DocumentMarker
into a new CompositionMarker subclass (similar to TextMatchMarker). I will do
the same for Spelling and Grammar markers in future CLs.
BUG=707867
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========
rlanday
The CQ bit was checked by rlanday@chromium.org to run a CQ dry run
3 years, 7 months ago
(2017-05-25 23:11:48 UTC)
#2
Dry run: Try jobs failed on following builders: android_arm64_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_arm64_dbg_recipe/builds/277436)
3 years, 6 months ago
(2017-05-26 22:50:40 UTC)
#11
Dry run: Try jobs failed on following builders: ios-simulator on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/builds/226576) mac_chromium_compile_dbg_ng on ...
3 years, 6 months ago
(2017-05-30 21:18:12 UTC)
#16
Dry run: Try jobs failed on following builders: linux_layout_tests_slimming_paint_v2 on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_layout_tests_slimming_paint_v2/builds/4806)
3 years, 6 months ago
(2017-05-31 21:34:03 UTC)
#22
Try jobs failed on following builders: android_arm64_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_arm64_dbg_recipe/builds/280330)
3 years, 6 months ago
(2017-06-01 05:30:04 UTC)
#28
CQ is committing da patch. Bot data: {"patchset_id": 120001, "attempt_start_ts": 1496295911427220, "parent_rev": "ed6724976ba56938ae7be863b63758456e0b2387", "commit_rev": "2546cdae560f745b5ee91856244bf12f36729e44"}
3 years, 6 months ago
(2017-06-01 07:29:23 UTC)
#32
CQ is committing da patch.
Bot data: {"patchset_id": 120001, "attempt_start_ts": 1496295911427220,
"parent_rev": "ed6724976ba56938ae7be863b63758456e0b2387", "commit_rev":
"2546cdae560f745b5ee91856244bf12f36729e44"}
commit-bot: I haz the power
Description was changed from ========== Add CompositionMarker (subclass of DocumentMarker) This CL moves the Composition ...
3 years, 6 months ago
(2017-06-01 07:29:34 UTC)
#33
Message was sent while issue was closed.
Description was changed from
==========
Add CompositionMarker (subclass of DocumentMarker)
This CL moves the Composition marker-specific functionality of DocumentMarker
into a new CompositionMarker subclass (similar to TextMatchMarker). I will do
the same for Spelling and Grammar markers in future CLs.
BUG=707867
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========
to
==========
Add CompositionMarker (subclass of DocumentMarker)
This CL moves the Composition marker-specific functionality of DocumentMarker
into a new CompositionMarker subclass (similar to TextMatchMarker). I will do
the same for Spelling and Grammar markers in future CLs.
BUG=707867
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Review-Url: https://codereview.chromium.org/2908643002
Cr-Commit-Position: refs/heads/master@{#476220}
Committed:
https://chromium.googlesource.com/chromium/src/+/2546cdae560f745b5ee91856244b...
==========
commit-bot: I haz the power
Committed patchset #7 (id:120001) as https://chromium.googlesource.com/chromium/src/+/2546cdae560f745b5ee91856244bf12f36729e44
3 years, 6 months ago
(2017-06-01 07:29:35 UTC)
#34
Issue 2908643002: [DMC #23] Add CompositionMarker (subclass of DocumentMarker)
(Closed)
Created 3 years, 7 months ago by rlanday
Modified 3 years, 6 months ago
Reviewers: tkent, Xiaocheng, yosin_UTC9
Base URL:
Comments: 8