Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1072)

Unified Diff: third_party/WebKit/Source/core/editing/markers/DocumentMarkerController.cpp

Issue 2908643002: [DMC #23] Add CompositionMarker (subclass of DocumentMarker) (Closed)
Patch Set: Attempt to fix Android build by using EXPECT_FALSE() Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/editing/markers/DocumentMarkerController.cpp
diff --git a/third_party/WebKit/Source/core/editing/markers/DocumentMarkerController.cpp b/third_party/WebKit/Source/core/editing/markers/DocumentMarkerController.cpp
index 545678929d4ee0cb63895f7027c62bf4c52bd45e..0064a7f4c21f0ce6fef7e6cac1c1b8d8ad02e76b 100644
--- a/third_party/WebKit/Source/core/editing/markers/DocumentMarkerController.cpp
+++ b/third_party/WebKit/Source/core/editing/markers/DocumentMarkerController.cpp
@@ -34,6 +34,7 @@
#include "core/dom/Text.h"
#include "core/editing/VisibleUnits.h"
#include "core/editing/iterators/TextIterator.h"
+#include "core/editing/markers/CompositionMarker.h"
#include "core/editing/markers/CompositionMarkerListImpl.h"
#include "core/editing/markers/DocumentMarkerListEditor.h"
#include "core/editing/markers/GrammarMarkerListImpl.h"
@@ -162,8 +163,8 @@ void DocumentMarkerController::AddCompositionMarker(const EphemeralRange& range,
DCHECK(!document_->NeedsLayoutTreeUpdate());
AddMarkerInternal(range, [underline_color, thick, background_color](
int start_offset, int end_offset) {
- return new DocumentMarker(start_offset, end_offset, underline_color, thick,
- background_color);
+ return new CompositionMarker(start_offset, end_offset, underline_color,
+ thick, background_color);
});
}

Powered by Google App Engine
This is Rietveld 408576698