Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(382)

Unified Diff: third_party/WebKit/Source/core/editing/markers/DocumentMarker.h

Issue 2908643002: [DMC #23] Add CompositionMarker (subclass of DocumentMarker) (Closed)
Patch Set: Attempt to fix Android build by using EXPECT_FALSE() Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/editing/markers/DocumentMarker.h
diff --git a/third_party/WebKit/Source/core/editing/markers/DocumentMarker.h b/third_party/WebKit/Source/core/editing/markers/DocumentMarker.h
index f0c8d38ab0761ec68219ab4e431cd4e4611bf80c..2d7169c8ef9e0b68e9800f4ad8ad448b96f3ead1 100644
--- a/third_party/WebKit/Source/core/editing/markers/DocumentMarker.h
+++ b/third_party/WebKit/Source/core/editing/markers/DocumentMarker.h
@@ -132,20 +132,12 @@ class CORE_EXPORT DocumentMarker : public GarbageCollected<DocumentMarker> {
unsigned start_offset,
unsigned end_offset,
const String& description);
- DocumentMarker(unsigned start_offset,
- unsigned end_offset,
- Color underline_color,
- bool thick,
- Color background_color);
MarkerType GetType() const { return type_; }
unsigned StartOffset() const { return start_offset_; }
unsigned EndOffset() const { return end_offset_; }
const String& Description() const;
- Color UnderlineColor() const;
- bool Thick() const;
- Color BackgroundColor() const;
DocumentMarkerDetails* Details() const;
void ClearDetails() { details_.Clear(); }
@@ -191,7 +183,6 @@ class DocumentMarkerDetails
DocumentMarkerDetails() {}
virtual ~DocumentMarkerDetails();
virtual bool IsDescription() const { return false; }
- virtual bool IsComposition() const { return false; }
DEFINE_INLINE_VIRTUAL_TRACE() {}
};

Powered by Google App Engine
This is Rietveld 408576698