[DMC #23] Add CompositionMarker (subclass of DocumentMarker)

Add CompositionMarker (subclass of DocumentMarker)

This CL moves the Composition marker-specific functionality of DocumentMarker
into a new CompositionMarker subclass (similar to TextMatchMarker). I will do
the same for Spelling and Grammar markers in future CLs.

BUG=707867
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Review-Url: https://codereview.chromium.org/2908643002
Cr-Commit-Position: refs/heads/master@{#476220}
Committed: https://chromium.googlesource.com/chromium/src/+/2546cdae560f745b5ee91856244bf12f36729e44

[rlanday, 2017-05-25 23:11:41]

Description was changed from

==========
Add CompositionMarker (subclass of DocumentMarker)

This CL moves the Composition marker-specific functionality of DocumentMarker
into a new CompositionMarker subclass (similar to TextMatchMarker). I will do
the same for Spelling and Grammar markers in future CLs.

BUG=707867
==========

to

==========
Add CompositionMarker (subclass of DocumentMarker)

This CL moves the Composition marker-specific functionality of DocumentMarker
into a new CompositionMarker subclass (similar to TextMatchMarker). I will do
the same for Spelling and Grammar markers in future CLs.

BUG=707867
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

[rlanday, 2017-05-25 23:11:48]

The CQ bit was checked by rlanday@chromium.org to run a CQ dry run

[rlanday, 2017-05-25 23:12:08]

rlanday@chromium.org changed reviewers:
+ xiaochengh@chromium.org, yosin@chromium.org

[commit-bot: I haz the power, 2017-05-25 23:12:45]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[yosin_UTC9, 2017-05-26 04:54:02]

https://codereview.chromium.org/2908643002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/editing/markers/CompositionMarker.h (right):

https://codereview.chromium.org/2908643002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/editing/markers/CompositionMarker.h:22: bool
thick,
Let's introduce |enum Tichkness { kThin, kThick }| in another patch to avoid
|bool| parameter.

https://codereview.chromium.org/2908643002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/editing/markers/CompositionMarker.h:26: bool
Thick() const;
Please rename |Thick()| to |IsThick()| in another patch.

https://codereview.chromium.org/2908643002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/editing/markers/CompositionMarker.h:31: bool
thick_;
Please move |bool thick_| to end of member variable to avoid padding for adding
another |bool| member in future and
to follow other classes.

https://codereview.chromium.org/2908643002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/editing/markers/CompositionMarker.h:33: };
Please add DISALLOW_COPY_AND_ASSIGN(...)

https://codereview.chromium.org/2908643002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/editing/markers/CompositionMarker.h:38:
marker->GetType() == DocumentMarker::kComposition,
Could you add CompositionMarkerTest.cpp to verify ctor and getters?:

- MarkerType()
- UnderlineColor()
- ... getters ...

[rlanday, 2017-05-26 19:54:18]

On 2017/05/26 at 04:54:02, yosin wrote:
>
https://codereview.chromium.org/2908643002/diff/20001/third_party/WebKit/Sour...
> File third_party/WebKit/Source/core/editing/markers/CompositionMarker.h
(right):
> 
>
https://codereview.chromium.org/2908643002/diff/20001/third_party/WebKit/Sour...
> third_party/WebKit/Source/core/editing/markers/CompositionMarker.h:22: bool
thick,
> Let's introduce |enum Tichkness { kThin, kThick }| in another patch to avoid
|bool| parameter.
> 
>
https://codereview.chromium.org/2908643002/diff/20001/third_party/WebKit/Sour...
> third_party/WebKit/Source/core/editing/markers/CompositionMarker.h:26: bool
Thick() const;
> Please rename |Thick()| to |IsThick()| in another patch.
> 
>
https://codereview.chromium.org/2908643002/diff/20001/third_party/WebKit/Sour...
> third_party/WebKit/Source/core/editing/markers/CompositionMarker.h:31: bool
thick_;
> Please move |bool thick_| to end of member variable to avoid padding for
adding another |bool| member in future and
> to follow other classes.
> 
>
https://codereview.chromium.org/2908643002/diff/20001/third_party/WebKit/Sour...
> third_party/WebKit/Source/core/editing/markers/CompositionMarker.h:33: };
> Please add DISALLOW_COPY_AND_ASSIGN(...)
> 
>
https://codereview.chromium.org/2908643002/diff/20001/third_party/WebKit/Sour...
> third_party/WebKit/Source/core/editing/markers/CompositionMarker.h:38:
marker->GetType() == DocumentMarker::kComposition,
> Could you add CompositionMarkerTest.cpp to verify ctor and getters?:
> 
> - MarkerType()
> - UnderlineColor()
> - ... getters ...

Updated

[rlanday, 2017-05-26 21:44:33]

The CQ bit was checked by rlanday@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-26 21:45:02]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-26 22:50:40]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-26 22:50:40]

Dry run: Try jobs failed on following builders:
  android_arm64_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_arm6...)

[yosin_UTC9, 2017-05-29 05:09:38]

lgtm w/ nits

https://codereview.chromium.org/2908643002/diff/60001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/editing/markers/CompositionMarker.h (right):

https://codereview.chromium.org/2908643002/diff/60001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/editing/markers/CompositionMarker.h:30: Color
underline_color_;
nit: s/Color/const Color/

https://codereview.chromium.org/2908643002/diff/60001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/editing/markers/CompositionMarker.h:31: Color
background_color_;
nit: s/Color/const Color/

https://codereview.chromium.org/2908643002/diff/60001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/editing/markers/CompositionMarker.h:32: bool
thick_;
nit: s/bool/const bool/

[rlanday, 2017-05-30 21:14:23]

The CQ bit was checked by rlanday@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-30 21:15:02]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-30 21:18:11]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-30 21:18:12]

Dry run: Try jobs failed on following builders:
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[rlanday, 2017-05-31 20:37:09]

The CQ bit was checked by rlanday@chromium.org to run a CQ dry run

[rlanday, 2017-05-31 20:38:21]

rlanday@chromium.org changed reviewers:
+ tkent@chromium.org

[rlanday, 2017-05-31 20:38:38]

Adding tkent@ as OWNER for
third_party/WebKit/Source/core/paint/InlineTextBoxPainter.cpp

[commit-bot: I haz the power, 2017-05-31 20:38:46]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-31 21:34:02]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-31 21:34:03]

Dry run: Try jobs failed on following builders:
  linux_layout_tests_slimming_paint_v2 on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_layout_te...)

[tkent, 2017-06-01 00:16:16]

lgtm

[rlanday, 2017-06-01 04:17:25]

The CQ bit was checked by rlanday@chromium.org

[rlanday, 2017-06-01 04:17:25]

The patchset sent to the CQ was uploaded after l-g-t-m from yosin@chromium.org
Link to the patchset: https://codereview.chromium.org/2908643002/#ps100001
(title: "Rebase")

[commit-bot: I haz the power, 2017-06-01 04:17:44]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-01 05:30:03]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-01 05:30:04]

Try jobs failed on following builders:
  android_arm64_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_arm6...)

[rlanday, 2017-06-01 05:45:11]

The CQ bit was checked by rlanday@chromium.org

[rlanday, 2017-06-01 05:45:11]

The patchset sent to the CQ was uploaded after l-g-t-m from tkent@chromium.org,
yosin@chromium.org
Link to the patchset: https://codereview.chromium.org/2908643002/#ps120001
(title: "Attempt to fix Android build by using EXPECT_FALSE()")

[commit-bot: I haz the power, 2017-06-01 05:45:23]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-01 07:29:23]

CQ is committing da patch.

Bot data: {"patchset_id": 120001, "attempt_start_ts": 1496295911427220,
"parent_rev": "ed6724976ba56938ae7be863b63758456e0b2387", "commit_rev":
"2546cdae560f745b5ee91856244bf12f36729e44"}

[commit-bot: I haz the power, 2017-06-01 07:29:34]

Description was changed from

==========
Add CompositionMarker (subclass of DocumentMarker)

This CL moves the Composition marker-specific functionality of DocumentMarker
into a new CompositionMarker subclass (similar to TextMatchMarker). I will do
the same for Spelling and Grammar markers in future CLs.

BUG=707867
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

to

==========
Add CompositionMarker (subclass of DocumentMarker)

This CL moves the Composition marker-specific functionality of DocumentMarker
into a new CompositionMarker subclass (similar to TextMatchMarker). I will do
the same for Spelling and Grammar markers in future CLs.

BUG=707867
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Review-Url: https://codereview.chromium.org/2908643002
Cr-Commit-Position: refs/heads/master@{#476220}
Committed:
https://chromium.googlesource.com/chromium/src/+/2546cdae560f745b5ee91856244b...
==========

[commit-bot: I haz the power, 2017-06-01 07:29:35]

Committed patchset #7 (id:120001) as
https://chromium.googlesource.com/chromium/src/+/2546cdae560f745b5ee91856244b...