[Payment Request] Refactors edit view controller

[Payment Request] Refactors edit view controller

-Adds support for switch fields in the PaymentRequestEditViewController.
-Refactors PaymentRequestEditViewController subclasses into their parent.

BUG=602666
TBR=jdonnelly@

Review-Url: https://codereview.chromium.org/2908033002
Cr-Commit-Position: refs/heads/master@{#475768}
Committed: https://chromium.googlesource.com/chromium/src/+/3f3baed790b15159e19c0ca7dfd03e150007d0a8

[Moe, 2017-05-29 03:29:01]

The CQ bit was checked by mahmadi@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-29 03:29:12]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Moe, 2017-05-29 03:44:39]

The CQ bit was checked by mahmadi@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-29 03:44:49]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Moe, 2017-05-29 03:44:53]

Patchset #1 (id:1) has been deleted

[Moe, 2017-05-29 03:47:39]

mahmadi@chromium.org changed reviewers:
+ lpromero@chromium.org

[Moe, 2017-05-29 03:47:40]

Hi Louis,
This is a long-awaited CL to get rid of inheritance in editor view controllers.
Please take a look. I will send a follow up CL that adds the new field types to
the showcase app and its tests.

[Moe, 2017-05-29 03:47:45]

The CQ bit was unchecked by mahmadi@chromium.org

[Moe, 2017-05-29 03:49:16]

Patchset #1 (id:20001) has been deleted

[lpromero, 2017-05-30 12:35:45]

Please update the description to remove the mention of the renaming, IIUC.

lgtm!

https://codereview.chromium.org/2908033002/diff/40001/ios/chrome/browser/ui/p...
File ios/chrome/browser/ui/payments/credit_card_edit_mediator.mm (right):

https://codereview.chromium.org/2908033002/diff/40001/ios/chrome/browser/ui/p...
ios/chrome/browser/ui/payments/credit_card_edit_mediator.mm:119: -
(UIImage*)iconIdentifyingEditorFied:(EditorField*)field {
s/Fied/Field. The typo is also in the protocol declaration.

https://codereview.chromium.org/2908033002/diff/40001/ios/chrome/browser/ui/p...
File ios/chrome/browser/ui/payments/payment_request_edit_view_controller.mm
(right):

https://codereview.chromium.org/2908033002/diff/40001/ios/chrome/browser/ui/p...
ios/chrome/browser/ui/payments/payment_request_edit_view_controller.mm:88:
PaymentRequestEditViewControllerActions,
Sort alphabetically.

[Moe, 2017-05-30 15:50:05]

Description was changed from

==========
[Payment Request] Refactors edit view controller

-Adds support for switch fields in the PaymentRequestEditViewController.
-Refactors PaymentRequestEditViewController subclasses into their parent.
-Renames a poorly named property of the AutofillEditItem.

BUG=602666
==========

to

==========
[Payment Request] Refactors edit view controller

-Adds support for switch fields in the PaymentRequestEditViewController.
-Refactors PaymentRequestEditViewController subclasses into their parent.

BUG=602666
==========

[Moe, 2017-05-30 19:52:31]

The CQ bit was checked by mahmadi@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-30 19:53:15]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-30 22:39:12]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-30 22:39:13]

Dry run: Try jobs failed on following builders:
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[Moe, 2017-05-31 02:07:04]

Description was changed from

==========
[Payment Request] Refactors edit view controller

-Adds support for switch fields in the PaymentRequestEditViewController.
-Refactors PaymentRequestEditViewController subclasses into their parent.

BUG=602666
==========

to

==========
[Payment Request] Refactors edit view controller

-Adds support for switch fields in the PaymentRequestEditViewController.
-Refactors PaymentRequestEditViewController subclasses into their parent.

BUG=602666

TBR=jdonnelly@
==========

[Moe, 2017-05-31 03:21:10]

The CQ bit was checked by mahmadi@chromium.org

[Moe, 2017-05-31 03:21:11]

Thank you.
TBR=jdonnelly@ for ios/chrome/browser/ui/autofill/

https://codereview.chromium.org/2908033002/diff/40001/ios/chrome/browser/ui/p...
File ios/chrome/browser/ui/payments/credit_card_edit_mediator.mm (right):

https://codereview.chromium.org/2908033002/diff/40001/ios/chrome/browser/ui/p...
ios/chrome/browser/ui/payments/credit_card_edit_mediator.mm:119: -
(UIImage*)iconIdentifyingEditorFied:(EditorField*)field {
On 2017/05/30 at 12:35:45, lpromero wrote:
> s/Fied/Field. The typo is also in the protocol declaration.

Done.

https://codereview.chromium.org/2908033002/diff/40001/ios/chrome/browser/ui/p...
File ios/chrome/browser/ui/payments/payment_request_edit_view_controller.mm
(right):

https://codereview.chromium.org/2908033002/diff/40001/ios/chrome/browser/ui/p...
ios/chrome/browser/ui/payments/payment_request_edit_view_controller.mm:88:
PaymentRequestEditViewControllerActions,
On 2017/05/30 at 12:35:45, lpromero wrote:
> Sort alphabetically.

Done.

[Moe, 2017-05-31 03:21:12]

The patchset sent to the CQ was uploaded after l-g-t-m from
lpromero@chromium.org
Link to the patchset: https://codereview.chromium.org/2908033002/#ps60001
(title: "Addressed comments")

[commit-bot: I haz the power, 2017-05-31 03:21:43]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-31 03:27:30]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1496200870002460,
"parent_rev": "cdadc3319167519dabd265361ce14a61c9106839", "commit_rev":
"3f3baed790b15159e19c0ca7dfd03e150007d0a8"}

[commit-bot: I haz the power, 2017-05-31 03:27:39]

Description was changed from

==========
[Payment Request] Refactors edit view controller

-Adds support for switch fields in the PaymentRequestEditViewController.
-Refactors PaymentRequestEditViewController subclasses into their parent.

BUG=602666

TBR=jdonnelly@
==========

to

==========
[Payment Request] Refactors edit view controller

-Adds support for switch fields in the PaymentRequestEditViewController.
-Refactors PaymentRequestEditViewController subclasses into their parent.

BUG=602666

TBR=jdonnelly@

Review-Url: https://codereview.chromium.org/2908033002
Cr-Commit-Position: refs/heads/master@{#475768}
Committed:
https://chromium.googlesource.com/chromium/src/+/3f3baed790b15159e19c0ca7dfd0...
==========

[commit-bot: I haz the power, 2017-05-31 03:27:41]

Committed patchset #2 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/3f3baed790b15159e19c0ca7dfd0...