[Payment Request] Refactors edit view controller

ios/chrome/browser/ui/payments/credit_card_edit_mediator.mm

 // Copyright 2017 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #import "ios/chrome/browser/ui/payments/credit_card_edit_mediator.h"
 
 #include "base/strings/sys_string_conversions.h"
 #include "components/autofill/core/browser/autofill_data_util.h"
 #include "components/autofill/core/browser/autofill_profile.h"
 #include "components/autofill/core/browser/credit_card.h"
 #include "components/autofill/core/browser/personal_data_manager.h"
 #import "components/autofill/ios/browser/credit_card_util.h"
 #include "components/strings/grit/components_strings.h"
 #include "ios/chrome/browser/application_context.h"
 #include "ios/chrome/browser/payments/payment_request.h"
 #import "ios/chrome/browser/payments/payment_request_util.h"
 #import "ios/chrome/browser/ui/autofill/autofill_ui_type.h"
-#import "ios/chrome/browser/ui/autofill/autofill_ui_type_util.h"
 #import "ios/chrome/browser/ui/payments/cells/accepted_payment_methods_item.h"
 #import "ios/chrome/browser/ui/payments/cells/payment_method_item.h"
 #import "ios/chrome/browser/ui/payments/payment_request_edit_consumer.h"
 #import "ios/chrome/browser/ui/payments/payment_request_editor_field.h"
 #import "ios/chrome/browser/ui/uikit_ui_util.h"
 #include "ui/base/l10n/l10n_util.h"
 
 #if !defined(__has_feature) || !__has_feature(objc_arc)
 #error "This file requires ARC support."
 #endif
 
 namespace {
-using ::AutofillUITypeFromAutofillType;
 using ::autofill::data_util::GetIssuerNetworkForBasicCardIssuerNetwork;
 using ::autofill::data_util::GetPaymentRequestData;
 using ::payment_request_util::GetBillingAddressLabelFromAutofillProfile;
 }  // namespace
 
 @interface CreditCardEditViewControllerMediator ()
 
 // The PaymentRequest object owning an instance of web::PaymentRequest as
 // provided by the page invoking the Payment Request API. This is a weak
 // pointer and should outlive this class.
@@ skipping 24 matching lines @@
   return self;
 }
 
 #pragma mark - Setters
 
 - (void)setConsumer:(id<PaymentRequestEditConsumer>)consumer {
   _consumer = consumer;
   [self.consumer setEditorFields:[self createEditorFields]];
 }
 
-#pragma mark - CreditCardEditViewControllerDataSource
+#pragma mark - PaymentRequestEditViewControllerDataSource
 
 - (CollectionViewItem*)headerItem {
   if (_creditCard && !autofill::IsCreditCardLocal(*_creditCard)) {
     // Return an item that identifies the server card being edited.
     PaymentMethodItem* cardSummaryItem = [[PaymentMethodItem alloc] init];
     cardSummaryItem.methodID =
         base::SysUTF16ToNSString(_creditCard->NetworkAndLastFourDigits());
     cardSummaryItem.methodDetail = base::SysUTF16ToNSString(
         _creditCard->GetRawInfo(autofill::CREDIT_CARD_NAME_FULL));
     const int issuerNetworkIconID =
@@ skipping 24 matching lines @@
       l10n_util::GetNSString(IDS_PAYMENTS_ACCEPTED_CARDS_LABEL);
   acceptedMethodsItem.methodTypeIcons = issuerNetworkIcons;
   return acceptedMethodsItem;
 }
 
 - (BOOL)shouldHideBackgroundForHeaderItem {
   // YES if the header item displays the accepted payment method type icons.
   return !_creditCard || autofill::IsCreditCardLocal(*_creditCard);
 }
 
-- (UIImage*)cardTypeIconFromCardNumber:(NSString*)cardNumber {
+- (UIImage*)iconIdentifyingEditorFied:(EditorField*)field {

[lpromero, 2017/05/30 12:35:45]

s/Fied/Field. The typo is also in the protocol declaration.

[Moe, 2017/05/31 03:21:11]

Done.

+  // Early return if the field is not the credit card number field.
+  if (field.autofillUIType != AutofillUITypeCreditCardNumber)
+    return nil;
+
   const char* issuerNetwork = autofill::CreditCard::GetCardNetwork(
-      base::SysNSStringToUTF16(cardNumber));
+      base::SysNSStringToUTF16(field.value));
   // This should not happen in Payment Request.
   if (issuerNetwork == autofill::kGenericCard)
     return nil;
 
   // Return the card issuer network icon.
   int resourceID = autofill::data_util::GetPaymentRequestData(issuerNetwork)
                        .icon_resource_id;
   return NativeImage(resourceID);
 }
 
@@ skipping 45 matching lines @@
   NSString* creditCardExpMonth =
       _creditCard
           ? [NSString stringWithFormat:@"%02d", _creditCard->expiration_month()]
           : nil;
 
   NSString* creditCardExpYear =
       _creditCard
           ? [NSString stringWithFormat:@"%04d", _creditCard->expiration_year()]
           : nil;
 
-  NSMutableArray* editorFields = [[NSMutableArray alloc] init];
-  [editorFields addObjectsFromArray:@[
+  return @[
     [[EditorField alloc]
-        initWithAutofillUIType:AutofillUITypeFromAutofillType(
-                                   autofill::CREDIT_CARD_NUMBER)
+        initWithAutofillUIType:AutofillUITypeCreditCardNumber
                      fieldType:EditorFieldTypeTextField
                          label:l10n_util::GetNSString(IDS_PAYMENTS_CARD_NUMBER)
                          value:creditCardNumber
                       required:YES],
     [[EditorField alloc]
-        initWithAutofillUIType:AutofillUITypeFromAutofillType(
-                                   autofill::CREDIT_CARD_NAME_FULL)
+        initWithAutofillUIType:AutofillUITypeCreditCardHolderFullName
                      fieldType:EditorFieldTypeTextField
                          label:l10n_util::GetNSString(IDS_PAYMENTS_NAME_ON_CARD)
                          value:creditCardName
                       required:YES],
     [[EditorField alloc]
-        initWithAutofillUIType:AutofillUITypeFromAutofillType(
-                                   autofill::CREDIT_CARD_EXP_MONTH)
+        initWithAutofillUIType:AutofillUITypeCreditCardExpMonth
                      fieldType:EditorFieldTypeTextField
                          label:l10n_util::GetNSString(IDS_PAYMENTS_EXP_MONTH)
                          value:creditCardExpMonth
                       required:YES],
     [[EditorField alloc]
-        initWithAutofillUIType:AutofillUITypeFromAutofillType(
-                                   autofill::CREDIT_CARD_EXP_4_DIGIT_YEAR)
+        initWithAutofillUIType:AutofillUITypeCreditCardExpYear
                      fieldType:EditorFieldTypeTextField
                          label:l10n_util::GetNSString(IDS_PAYMENTS_EXP_YEAR)
                          value:creditCardExpYear
-                      required:YES]
-  ]];
-  // The billing address field goes at the end.
-  [editorFields addObject:billingAddressEditorField];
-  return editorFields;
+                      required:YES],
+    billingAddressEditorField,
+    [[EditorField alloc]
+        initWithAutofillUIType:AutofillUITypeCreditCardSaveToChrome
+                     fieldType:EditorFieldTypeSwitch
+                         label:l10n_util::GetNSString(
+                                   IDS_PAYMENTS_SAVE_CARD_TO_DEVICE_CHECKBOX)
+                         value:@"YES"
+                      required:YES],
+  ];
 }
 
 @end