[Payment Request] Updates PaymentRequestEditViewController in showcase

[Payment Request] Updates PaymentRequestEditViewController in showcase

* Adds a switch field and a text field with a UIPickerView as input view.
* Sets UIPickerView's default selected row in the view controller.
* Updates EG tests.

http://imgur.com/a/B7jaZ

BUG=602666
Review-Url: https://codereview.chromium.org/2907103002
Cr-Commit-Position: refs/heads/master@{#475883}
Committed: https://chromium.googlesource.com/chromium/src/+/7644280ec41728613b951df0e1c5b71d4eea73f5

[Moe, 2017-05-29 04:10:26]

mahmadi@chromium.org changed reviewers:
+ lpromero@chromium.org

[Moe, 2017-05-29 04:10:27]

Hi Louis, Please take a look.

[Moe, 2017-05-29 13:41:20]

Description was changed from

==========
[Payment Request] Updates PaymentRequestEditViewController in showcase

* Adds a switch field and a text field with a UIPickerView as input view.
* Sets UIPickerView's default selected row in the view controller.
* Updates EG tests.

BUG=602666
==========

to

==========
[Payment Request] Updates PaymentRequestEditViewController in showcase

* Adds a switch field and a text field with a UIPickerView as input view.
* Sets UIPickerView's default selected row in the view controller.
* Updates EG tests.

http://imgur.com/a/B7jaZ

BUG=602666
==========

[lpromero, 2017-05-30 11:50:36]

lgtm

https://codereview.chromium.org/2907103002/diff/1/ios/chrome/browser/ui/payme...
File ios/chrome/browser/ui/payments/payment_request_edit_view_controller.mm
(right):

https://codereview.chromium.org/2907103002/diff/1/ios/chrome/browser/ui/payme...
ios/chrome/browser/ui/payments/payment_request_edit_view_controller.mm:334:
animated:YES];
Since you are just creating the picker, does it need to animate the selection
here?

https://codereview.chromium.org/2907103002/diff/1/ios/showcase/payments/sc_pa...
File ios/showcase/payments/sc_payments_editor_egtest.mm (right):

https://codereview.chromium.org/2907103002/diff/1/ios/showcase/payments/sc_pa...
ios/showcase/payments/sc_payments_editor_egtest.mm:310: // The standard keyboard
does not display for the provonce field. Instead, tap
*province

[Moe, 2017-05-31 03:33:09]

The CQ bit was checked by mahmadi@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-31 03:33:31]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-31 03:42:26]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-31 03:42:27]

Dry run: Try jobs failed on following builders:
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)

[Moe, 2017-05-31 04:15:15]

Patchset #2 (id:20001) has been deleted

[Moe, 2017-05-31 04:15:35]

The CQ bit was checked by mahmadi@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-31 04:15:47]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-31 05:42:23]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-31 05:42:24]

Dry run: This issue passed the CQ dry run.

[Moe, 2017-05-31 12:04:57]

The CQ bit was checked by mahmadi@chromium.org

[Moe, 2017-05-31 12:04:58]

Thank you.

https://codereview.chromium.org/2907103002/diff/1/ios/chrome/browser/ui/payme...
File ios/chrome/browser/ui/payments/payment_request_edit_view_controller.mm
(right):

https://codereview.chromium.org/2907103002/diff/1/ios/chrome/browser/ui/payme...
ios/chrome/browser/ui/payments/payment_request_edit_view_controller.mm:334:
animated:YES];
On 2017/05/30 at 11:50:36, lpromero wrote:
> Since you are just creating the picker, does it need to animate the selection
here?

Done.

https://codereview.chromium.org/2907103002/diff/1/ios/showcase/payments/sc_pa...
File ios/showcase/payments/sc_payments_editor_egtest.mm (right):

https://codereview.chromium.org/2907103002/diff/1/ios/showcase/payments/sc_pa...
ios/showcase/payments/sc_payments_editor_egtest.mm:310: // The standard keyboard
does not display for the provonce field. Instead, tap
On 2017/05/30 at 11:50:36, lpromero wrote:
> *province

Done.

[Moe, 2017-05-31 12:04:58]

The patchset sent to the CQ was uploaded after l-g-t-m from
lpromero@chromium.org
Link to the patchset: https://codereview.chromium.org/2907103002/#ps40001
(title: "Addressed comments + fixed broken build")

[commit-bot: I haz the power, 2017-05-31 12:05:11]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-31 12:08:55]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1496232297636750,
"parent_rev": "8bd4bd710f34bc391ce1ff336f95347b2b374597", "commit_rev":
"7644280ec41728613b951df0e1c5b71d4eea73f5"}

[commit-bot: I haz the power, 2017-05-31 12:09:11]

Description was changed from

==========
[Payment Request] Updates PaymentRequestEditViewController in showcase

* Adds a switch field and a text field with a UIPickerView as input view.
* Sets UIPickerView's default selected row in the view controller.
* Updates EG tests.

http://imgur.com/a/B7jaZ

BUG=602666
==========

to

==========
[Payment Request] Updates PaymentRequestEditViewController in showcase

* Adds a switch field and a text field with a UIPickerView as input view.
* Sets UIPickerView's default selected row in the view controller.
* Updates EG tests.

http://imgur.com/a/B7jaZ

BUG=602666

Review-Url: https://codereview.chromium.org/2907103002
Cr-Commit-Position: refs/heads/master@{#475883}
Committed:
https://chromium.googlesource.com/chromium/src/+/7644280ec41728613b951df0e1c5...
==========

[commit-bot: I haz the power, 2017-05-31 12:09:13]

Committed patchset #2 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/7644280ec41728613b951df0e1c5...