Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7)

Issue 2911883002: [Payment Request] Renames a poorly named property of the AutofillEditItem. (Closed)

Created:
3 years, 6 months ago by Moe
Modified:
3 years, 6 months ago
Reviewers:
lpromero
CC:
chromium-reviews, estade+watch_chromium.org, ios-reviews_chromium.org, ios-reviews+chrome_chromium.org, marq+watch_chromium.org, mathp+autofillwatch_chromium.org, noyau+watch_chromium.org, pkl (ping after 24h if needed), rogerm+autofillwatch_chromium.org, rouslan+autofill_chromium.org, sebsg+autofillwatch_chromium.org, vabr+watchlistautofill_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[Payment Request] Renames a poorly named property of the AutofillEditItem. BUG=602666 TBR=jdonnelly@ Review-Url: https://codereview.chromium.org/2911883002 Cr-Commit-Position: refs/heads/master@{#475610} Committed: https://chromium.googlesource.com/chromium/src/+/dad95fb184292aefd86ba3b1136d4ed4bc59639b

Patch Set 1 : Initial #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -24 lines) Patch
M ios/chrome/browser/ui/autofill/cells/autofill_edit_item.h View 2 chunks +4 lines, -4 lines 0 comments Download
M ios/chrome/browser/ui/autofill/cells/autofill_edit_item.mm View 7 chunks +15 lines, -15 lines 0 comments Download
M ios/chrome/browser/ui/payments/credit_card_edit_view_controller.mm View 2 chunks +2 lines, -2 lines 0 comments Download
M ios/chrome/browser/ui/settings/autofill_credit_card_edit_collection_view_controller.mm View 2 chunks +2 lines, -2 lines 0 comments Download
M ios/chrome/browser/ui/settings/material_cell_catalog_view_controller.mm View 1 chunk +1 line, -1 line 0 comments Download

Dependent Patchsets:

Messages

Total messages: 19 (12 generated)
Moe
Hi Louis, Please take a look.
3 years, 6 months ago (2017-05-29 03:40:22 UTC) #5
lpromero
lgtm Thanks for having separated from the other changes :)
3 years, 6 months ago (2017-05-30 11:46:49 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2911883002/20001
3 years, 6 months ago (2017-05-30 11:47:09 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/450624)
3 years, 6 months ago (2017-05-30 11:53:55 UTC) #12
Moe
On 2017/05/30 at 11:53:55, commit-bot wrote: > Try jobs failed on following builders: > chromium_presubmit ...
3 years, 6 months ago (2017-05-30 18:39:50 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2911883002/20001
3 years, 6 months ago (2017-05-30 18:40:55 UTC) #16
commit-bot: I haz the power
3 years, 6 months ago (2017-05-30 18:47:25 UTC) #19
Message was sent while issue was closed.
Committed patchset #1 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/dad95fb184292aefd86ba3b1136d...

Powered by Google App Engine
This is Rietveld 408576698