Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(16)

Issue 2907853002: [mus+ash] Removes WmWindow from ash/shelf and ash/shell (Closed)

Created:
3 years, 7 months ago by varkha
Modified:
3 years, 7 months ago
Reviewers:
sky
CC:
chromium-reviews, blakeo+virtualkb_chromium.org, sadrul, posciak+watch_chromium.org, dcheng, oka+watchvk_chromium.org, yhanada+watchvk_chromium.org, kalyank, dfaden+virtualkb_google.com, groby+virtualkb_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[mus+ash] Removes WmWindow from ash/shelf and ash/shell BUG=722553 TEST=None (refactoring) Review-Url: https://codereview.chromium.org/2907853002 Cr-Commit-Position: refs/heads/master@{#475025} Committed: https://chromium.googlesource.com/chromium/src/+/6b016b0f9a7cedd416dfc47b09e9b1da7f5d22da

Patch Set 1 #

Patch Set 2 : [mus+ash] Removes WmWindow from ash/shelf and ash/shell (removed some more wm_window.h) #

Unified diffs Side-by-side diffs Delta from patch set Stats (+151 lines, -188 lines) Patch
M ash/root_window_controller.h View 1 chunk +1 line, -0 lines 0 comments Download
M ash/root_window_controller.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M ash/shelf/shelf.h View 4 chunks +4 lines, -5 lines 0 comments Download
M ash/shelf/shelf.cc View 4 chunks +9 lines, -9 lines 0 comments Download
M ash/shelf/shelf_controller.cc View 3 chunks +9 lines, -3 lines 0 comments Download
M ash/shelf/shelf_layout_manager.h View 1 chunk +1 line, -1 line 0 comments Download
M ash/shelf/shelf_layout_manager.cc View 1 chunk +2 lines, -1 line 0 comments Download
M ash/shelf/shelf_layout_manager_unittest.cc View 4 chunks +5 lines, -10 lines 0 comments Download
M ash/shelf/shelf_view_unittest.cc View 2 chunks +1 line, -4 lines 0 comments Download
M ash/shelf/shelf_widget.h View 3 chunks +4 lines, -5 lines 0 comments Download
M ash/shelf/shelf_widget.cc View 7 chunks +18 lines, -21 lines 0 comments Download
M ash/shell.h View 2 chunks +3 lines, -4 lines 0 comments Download
M ash/shell.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M ash/shell_observer.h View 2 chunks +3 lines, -5 lines 0 comments Download
M ash/system/palette/palette_tray.cc View 1 2 chunks +1 line, -2 lines 0 comments Download
M ash/system/toast/toast_manager_unittest.cc View 6 chunks +5 lines, -6 lines 0 comments Download
M ash/system/virtual_keyboard/virtual_keyboard_tray.cc View 2 chunks +4 lines, -3 lines 0 comments Download
M ash/system/web_notification/ash_popup_alignment_delegate.cc View 3 chunks +4 lines, -4 lines 0 comments Download
M ash/test/test_shell_delegate.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M ash/wm/always_on_top_controller_unittest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M ash/wm/default_state.cc View 1 chunk +0 lines, -1 line 0 comments Download
M ash/wm/drag_window_controller.cc View 1 chunk +0 lines, -1 line 0 comments Download
M ash/wm/drag_window_resizer.cc View 1 chunk +0 lines, -1 line 0 comments Download
M ash/wm/drag_window_resizer_unittest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M ash/wm/immersive_context_ash.cc View 3 chunks +10 lines, -7 lines 0 comments Download
M ash/wm/lock_layout_manager.cc View 1 chunk +0 lines, -1 line 0 comments Download
M ash/wm/panels/attached_panel_window_targeter.h View 1 chunk +2 lines, -2 lines 0 comments Download
M ash/wm/panels/attached_panel_window_targeter.cc View 2 chunks +4 lines, -5 lines 0 comments Download
M ash/wm/panels/panel_frame_view.h View 1 chunk +1 line, -1 line 0 comments Download
M ash/wm/panels/panel_frame_view.cc View 6 chunks +11 lines, -10 lines 0 comments Download
M ash/wm/panels/panel_layout_manager.h View 1 chunk +1 line, -1 line 0 comments Download
M ash/wm/panels/panel_layout_manager.cc View 5 chunks +5 lines, -8 lines 0 comments Download
M ash/wm/panels/panel_layout_manager_unittest.cc View 4 chunks +9 lines, -13 lines 0 comments Download
M ash/wm/panels/panel_window_resizer.cc View 2 chunks +1 line, -3 lines 0 comments Download
M ash/wm/panels/panel_window_resizer_unittest.cc View 2 chunks +2 lines, -3 lines 0 comments Download
M ash/wm/screen_dimmer.cc View 1 chunk +0 lines, -1 line 0 comments Download
M ash/wm/screen_dimmer_unittest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M ash/wm/screen_pinning_controller.cc View 1 chunk +0 lines, -1 line 0 comments Download
M ash/wm/screen_pinning_controller_unittest.cc View 7 chunks +10 lines, -11 lines 0 comments Download
M ash/wm/system_gesture_event_filter_unittest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M ash/wm/video_detector.cc View 1 chunk +0 lines, -1 line 0 comments Download
M ash/wm/window_animations.cc View 2 chunks +1 line, -3 lines 0 comments Download
M ash/wm/window_cycle_controller.cc View 1 chunk +0 lines, -1 line 0 comments Download
M ash/wm/window_cycle_controller_unittest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M ash/wm/window_cycle_list.cc View 2 chunks +1 line, -1 line 0 comments Download
M ash/wm/window_mirror_view.cc View 1 chunk +0 lines, -1 line 0 comments Download
M ash/wm/window_positioner.cc View 2 chunks +6 lines, -3 lines 0 comments Download
M ash/wm/window_positioner_unittest.cc View 1 1 chunk +0 lines, -1 line 0 comments Download
M ash/wm/window_positioning_utils.cc View 1 1 chunk +0 lines, -1 line 0 comments Download
M ash/wm/window_resizer.cc View 1 1 chunk +0 lines, -1 line 0 comments Download
M ash/wm/window_state_util.cc View 1 1 chunk +0 lines, -1 line 0 comments Download
M ash/wm/window_util.cc View 1 1 chunk +0 lines, -1 line 0 comments Download
M ash/wm/window_util_unittest.cc View 1 1 chunk +0 lines, -1 line 0 comments Download
M ash/wm/workspace_controller_unittest.cc View 1 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/ash/launcher/chrome_launcher_controller.cc View 2 chunks +1 line, -2 lines 0 comments Download
M chrome/browser/ui/ash/launcher/launcher_context_menu.cc View 2 chunks +4 lines, -3 lines 0 comments Download

Messages

Total messages: 15 (11 generated)
varkha
sky@, can you please take a look? There's still some usage left in ash/wm, I ...
3 years, 7 months ago (2017-05-26 15:22:50 UTC) #4
sky
LGTM
3 years, 7 months ago (2017-05-26 15:31:47 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2907853002/20001
3 years, 7 months ago (2017-05-26 16:07:53 UTC) #11
commit-bot: I haz the power
3 years, 7 months ago (2017-05-26 16:15:00 UTC) #15
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/6b016b0f9a7cedd416dfc47b09e9...

Powered by Google App Engine
This is Rietveld 408576698