VR: Disable select element in VR mode via WebPreferences

VR: Disable select element in VR mode via WebPreferences

When in VR, html select element opens a monocular popup UI widget.
page_popups_suppressed flag from web_preferences is used to suppress
the monocular ui.

BUG=726386
Review-Url: https://codereview.chromium.org/2905873003
Cr-Commit-Position: refs/heads/master@{#474862}
Committed: https://chromium.googlesource.com/chromium/src/+/dc76416e2ba1b9669cf7240ca693b8d38c8ba989

[asimjour1, 2017-05-25 17:41:09]

Description was changed from

==========
VR: Disable select element in VR mode via WebPreferences

When in VR, html select element opens a monocular popup UI widget.
page_popups_suppressed flag from web_preferences is used to suppress
the monocular ui.

BUG=726386
==========

to

==========
VR: Disable select element in VR mode via WebPreferences

When in VR, html select element opens a monocular popup UI widget.
page_popups_suppressed flag from web_preferences is used to suppress
the monocular ui.

BUG=726386
==========

[asimjour1, 2017-05-25 17:41:09]

asimjour@chromium.org changed reviewers:
+ vollick@chromium.org

[asimjour1, 2017-05-25 17:46:05]

asimjour@chromium.org changed reviewers:
+ rbyers@chromium.org

[asimjour1, 2017-05-25 17:46:05]

PTAL

[Rick Byers, 2017-05-25 21:06:17]

LGTM with nit

https://codereview.chromium.org/2905873003/diff/1/third_party/WebKit/Source/w...
File third_party/WebKit/Source/web/ChromeClientImpl.cpp (right):

https://codereview.chromium.org/2905873003/diff/1/third_party/WebKit/Source/w...
third_party/WebKit/Source/web/ChromeClientImpl.cpp:936: if
(frame.GetDocument()->GetSettings()->GetPagePopupsSuppressed())
nit: in vollick's previous CL he bailed out before a
'NotifyPopupOpeningObservers' call.  I don't know the implications of doing this
before or after, but I think we should at least be consistent.

[asimjour, 2017-05-25 22:47:31]

asimjour@google.com changed reviewers:
+ asimjour@google.com

[asimjour, 2017-05-25 22:47:32]

https://codereview.chromium.org/2905873003/diff/1/third_party/WebKit/Source/w...
File third_party/WebKit/Source/web/ChromeClientImpl.cpp (right):

https://codereview.chromium.org/2905873003/diff/1/third_party/WebKit/Source/w...
third_party/WebKit/Source/web/ChromeClientImpl.cpp:936: if
(frame.GetDocument()->GetSettings()->GetPagePopupsSuppressed())
On 2017/05/25 21:06:17, Rick Byers wrote:
> nit: in vollick's previous CL he bailed out before a
> 'NotifyPopupOpeningObservers' call.  I don't know the implications of doing
this
> before or after, but I think we should at least be consistent.

Done.

[asimjour1, 2017-05-25 22:59:09]

The CQ bit was checked by asimjour@chromium.org

[asimjour1, 2017-05-25 22:59:09]

The patchset sent to the CQ was uploaded after l-g-t-m from rbyers@chromium.org
Link to the patchset: https://codereview.chromium.org/2905873003/#ps20001
(title: "Address the comment")

[commit-bot: I haz the power, 2017-05-25 22:59:41]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-26 01:14:41]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1495753149084890,
"parent_rev": "21b5bb81bf3acaad3f32f53950b4aeb1496724d7", "commit_rev":
"dc76416e2ba1b9669cf7240ca693b8d38c8ba989"}

[commit-bot: I haz the power, 2017-05-26 01:14:52]

Description was changed from

==========
VR: Disable select element in VR mode via WebPreferences

When in VR, html select element opens a monocular popup UI widget.
page_popups_suppressed flag from web_preferences is used to suppress
the monocular ui.

BUG=726386
==========

to

==========
VR: Disable select element in VR mode via WebPreferences

When in VR, html select element opens a monocular popup UI widget.
page_popups_suppressed flag from web_preferences is used to suppress
the monocular ui.

BUG=726386

Review-Url: https://codereview.chromium.org/2905873003
Cr-Commit-Position: refs/heads/master@{#474862}
Committed:
https://chromium.googlesource.com/chromium/src/+/dc76416e2ba1b9669cf7240ca693...
==========

[commit-bot: I haz the power, 2017-05-26 01:14:53]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/dc76416e2ba1b9669cf7240ca693...