third_party/WebKit/Source/web/ChromeClientImpl.cpp - Issue 2905873003: VR: Disable select element in VR mode via WebPreferences

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/web/ChromeClientImpl.cpp

Issue 2905873003: VR: Disable select element in VR mode via WebPreferences (Closed)

Patch Set: Address the comment Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/web/ChromeClientImpl.cpp

diff --git a/third_party/WebKit/Source/web/ChromeClientImpl.cpp b/third_party/WebKit/Source/web/ChromeClientImpl.cpp

index c530e82bde81dccf45383e65a34b7626352b1f6f..2a35f2c1d8715e6d8aab6221edc1917f4780aca5 100644

--- a/third_party/WebKit/Source/web/ChromeClientImpl.cpp

+++ b/third_party/WebKit/Source/web/ChromeClientImpl.cpp

@@ -931,6 +931,9 @@ bool ChromeClientImpl::HasOpenedPopup() const {

PopupMenu* ChromeClientImpl::OpenPopupMenu(LocalFrame& frame,

HTMLSelectElement& select) {

+ if (frame.GetDocument()->GetSettings()->GetPagePopupsSuppressed())

+ return nullptr;

NotifyPopupOpeningObservers();

if (WebViewBase::UseExternalPopupMenus())

return new ExternalPopupMenu(frame, select, *web_view_);