Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(281)

Unified Diff: third_party/WebKit/Source/core/html/HTMLSelectElement.cpp

Issue 2905873003: VR: Disable select element in VR mode via WebPreferences (Closed)
Patch Set: Address the comment Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | third_party/WebKit/Source/web/ChromeClientImpl.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/core/html/HTMLSelectElement.cpp
diff --git a/third_party/WebKit/Source/core/html/HTMLSelectElement.cpp b/third_party/WebKit/Source/core/html/HTMLSelectElement.cpp
index 9830da4f64792410d883ba2eec74fb7ea779f764..cc47e407a1b57635e3b0d07aa37ae655078c979e 100644
--- a/third_party/WebKit/Source/core/html/HTMLSelectElement.cpp
+++ b/third_party/WebKit/Source/core/html/HTMLSelectElement.cpp
@@ -1949,6 +1949,9 @@ void HTMLSelectElement::ShowPopup() {
if (!popup_)
popup_ = GetDocument().GetPage()->GetChromeClient().OpenPopupMenu(
*GetDocument().GetFrame(), *this);
+ if (!popup_)
+ return;
+
popup_is_visible_ = true;
ObserveTreeMutation();
« no previous file with comments | « no previous file | third_party/WebKit/Source/web/ChromeClientImpl.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698