VR: Disable select element in VR mode via WebPreferences

third_party/WebKit/Source/web/ChromeClientImpl.cpp

 /*
  * Copyright (C) 2009 Google Inc. All rights reserved.
  * Copyright (C) 2010 Nokia Corporation and/or its subsidiary(-ies).
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
@@ skipping 914 matching lines @@
     layer_tree_view->RegisterSelection(WebSelection(selection));
 }
 
 bool ChromeClientImpl::HasOpenedPopup() const {
   return web_view_->HasOpenedPopup();
 }
 
 PopupMenu* ChromeClientImpl::OpenPopupMenu(LocalFrame& frame,
                                            HTMLSelectElement& select) {
   NotifyPopupOpeningObservers();
+
+  if (frame.GetDocument()->GetSettings()->GetPagePopupsSuppressed())

[Rick Byers, 2017/05/25 21:06:17]

nit: in vollick's previous CL he bailed out before a
'NotifyPopupOpeningObservers' call.  I don't know the implications of doing this
before or after, but I think we should at least be consistent.

[asimjour, 2017/05/25 22:47:32]

Done.

+    return nullptr;
+
   if (WebViewBase::UseExternalPopupMenus())
     return new ExternalPopupMenu(frame, select, *web_view_);
 
   DCHECK(RuntimeEnabledFeatures::pagePopupEnabled());
   return PopupMenuImpl::Create(this, select);
 }
 
 PagePopup* ChromeClientImpl::OpenPagePopup(PagePopupClient* client) {
   return web_view_->OpenPagePopup(client);
 }
@@ skipping 328 matching lines @@
   if (RuntimeEnabledFeatures::presentationEnabled())
     PresentationController::ProvideTo(frame, client->PresentationClient());
   if (RuntimeEnabledFeatures::audioOutputDevicesEnabled()) {
     ProvideAudioOutputDeviceClientTo(frame,
                                      new AudioOutputDeviceClientImpl(frame));
   }
   InstalledAppController::ProvideTo(frame, client->GetRelatedAppsFetcher());
 }
 
 }  // namespace blink