Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(148)

Issue 2904683002: [Cast, Android] The 2nd try to replace TransportXX classes in Cast UI (Closed)

Created:
3 years, 7 months ago by whywhat
Modified:
3 years, 7 months ago
Reviewers:
Nico, dgn
CC:
agrieve+watch_chromium.org, chromium-reviews, feature-media-reviews_chromium.org, jbudorick+watch_chromium.org, mikecase+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[Cast, Android] The 2nd try to replace TransportXX classes in Cast UI It's a revert of [Cast,Android] Replace custom MediaController with android.widget.MediaController. (patchset #2 id:20001 of https://codereview.chromium.org/2888653002/ ) with https://codereview.chromium.org/2895263005 added on top. The revert can't land separately as it will break the O build. Reason for revert: The CL caused a crash: https://bugs.chromium.org/p/chromium/issues/detail?id=725028 The revert can't be submitted though as the previous version will break the build. Original issue's description: > [Cast,Android] Replace custom MediaController with android.widget.MediaController. > > BUG=722688 > TEST=manual (cast a video from Chrome and tap on the notification, test the fullscreen controls) > > Review-Url: https://codereview.chromium.org/2888653002 > Cr-Commit-Position: refs/heads/master@{#472583} > Committed: https://chromium.googlesource.com/chromium/src/+/41ecb285107a4f13871031481cb865763779d87f TBR=dgn@chromium.org,thakis@chromium.org BUG=722688 Review-Url: https://codereview.chromium.org/2904683002 Cr-Commit-Position: refs/heads/master@{#475120} Committed: https://chromium.googlesource.com/chromium/src/+/7c2a83b27160f624fa430fd07e16d723816cf2ff

Patch Set 1 #

Patch Set 2 : Rebase #

Patch Set 3 : Added the fix on top of the revert #

Unified diffs Side-by-side diffs Delta from patch set Stats (+832 lines, -114 lines) Patch
M chrome/android/BUILD.gn View 1 2 chunks +2 lines, -1 line 0 comments Download
M chrome/android/java/res/layout/expanded_cast_controller.xml View 1 chunk +6 lines, -0 lines 0 comments Download
M chrome/android/java/res/values/colors.xml View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/media/remote/ExpandedControllerActivity.java View 1 2 13 chunks +69 lines, -112 lines 0 comments Download
A third_party/android_media/BUILD.gn View 1 chunk +26 lines, -0 lines 0 comments Download
A third_party/android_media/LICENSE View 1 chunk +202 lines, -0 lines 0 comments Download
A third_party/android_media/OWNERS View 1 chunk +3 lines, -0 lines 0 comments Download
A third_party/android_media/README.chromium View 1 2 1 chunk +20 lines, -0 lines 0 comments Download
A third_party/android_media/java/res/layout/media_controller.xml View 1 chunk +99 lines, -0 lines 0 comments Download
A third_party/android_media/java/res/values/colors.xml View 1 chunk +12 lines, -0 lines 0 comments Download
A third_party/android_media/java/src/org/chromium/third_party/android/media/MediaController.java View 1 2 1 chunk +391 lines, -0 lines 0 comments Download
M tools/android/eclipse/.classpath View 1 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 28 (20 generated)
whywhat
Created Revert of [Cast,Android] Replace custom MediaController with android.widget.MediaController.
3 years, 7 months ago (2017-05-23 21:31:40 UTC) #1
whywhat
Rebase
3 years, 7 months ago (2017-05-26 15:30:35 UTC) #6
whywhat
Added the fix on top of the revert
3 years, 7 months ago (2017-05-26 15:36:58 UTC) #8
dgn
lgtm
3 years, 7 months ago (2017-05-26 15:41:47 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2904683002/250001
3 years, 7 months ago (2017-05-26 18:16:24 UTC) #21
commit-bot: I haz the power
Try jobs failed on following builders: linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_android_rel_ng/builds/304556)
3 years, 7 months ago (2017-05-26 19:29:38 UTC) #23
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2904683002/250001
3 years, 7 months ago (2017-05-26 20:04:53 UTC) #25
commit-bot: I haz the power
3 years, 7 months ago (2017-05-26 20:54:31 UTC) #28
Message was sent while issue was closed.
Committed patchset #3 (id:250001) as
https://chromium.googlesource.com/chromium/src/+/7c2a83b27160f624fa430fd07e16...

Powered by Google App Engine
This is Rietveld 408576698