[Cast,Android] Replace custom MediaController with android.widget.MediaController.

[Cast,Android] Replace custom MediaController with android.widget.MediaController.

BUG=722688
TEST=manual (cast a video from Chrome and tap on the notification, test the fullscreen controls)

Review-Url: https://codereview.chromium.org/2888653002
Cr-Commit-Position: refs/heads/master@{#472583}
Committed: https://chromium.googlesource.com/chromium/src/+/41ecb285107a4f13871031481cb865763779d87f

[whywhat, 2017-05-16 19:07:42]

The CQ bit was checked by avayvod@chromium.org to run a CQ dry run

[whywhat, 2017-05-16 19:08:44]

avayvod@chromium.org changed reviewers:
+ dgn@chromium.org, thakis@chromium.org

[whywhat, 2017-05-16 19:08:44]

PTaL

dgn: chrome/android/java/*
thakis: chrome/android/BUILD.gn and deletion of third_party/android_media/

[commit-bot: I haz the power, 2017-05-16 19:09:24]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Nico, 2017-05-16 19:13:26]

"android.widget. one" in CL description looks like a typo.

TEST= is supposed to describe _how_ to manually test things, so that a QA person
could follow the steps listed there.

lgtm

https://codereview.chromium.org/2888653002/diff/1/chrome/android/java/res/val...
File chrome/android/java/res/values/colors.xml (right):

https://codereview.chromium.org/2888653002/diff/1/chrome/android/java/res/val...
chrome/android/java/res/values/colors.xml:219: <color
name="cast_media_controller_text">#bebebe</color>
dedent by 1

[whywhat, 2017-05-16 19:50:31]

Description was changed from

==========
[Cast,Android] Replaced sample MediaController with android.widget. one

BUG=722688
TEST=manual
==========

to

==========
[Cast,Android] Replace the third_party/android_media MediaController with
android.widget.MediaController

BUG=722688
TEST=manual (cast a video from Chrome and tap on the notification, test the
fullscreen controls)
==========

[whywhat, 2017-05-16 19:51:23]

On 2017/05/16 at 19:13:26, thakis wrote:
> "android.widget. one" in CL description looks like a typo.

Changed that to be less confusing.

> 
> TEST= is supposed to describe _how_ to manually test things, so that a QA
person could follow the steps listed there.
> 
Expanded the description.

> lgtm
> 
>
https://codereview.chromium.org/2888653002/diff/1/chrome/android/java/res/val...
> File chrome/android/java/res/values/colors.xml (right):
> 
>
https://codereview.chromium.org/2888653002/diff/1/chrome/android/java/res/val...
> chrome/android/java/res/values/colors.xml:219: <color
name="cast_media_controller_text">#bebebe</color>
> dedent by 1

Thanks!

[whywhat, 2017-05-16 19:51:28]

https://codereview.chromium.org/2888653002/diff/1/chrome/android/java/res/val...
File chrome/android/java/res/values/colors.xml (right):

https://codereview.chromium.org/2888653002/diff/1/chrome/android/java/res/val...
chrome/android/java/res/values/colors.xml:219: <color
name="cast_media_controller_text">#bebebe</color>
On 2017/05/16 at 19:13:26, Nico wrote:
> dedent by 1

Done.

[whywhat, 2017-05-16 19:52:15]

Dedented the color in the xml file.

[whywhat, 2017-05-16 20:16:47]

Description was changed from

==========
[Cast,Android] Replace the third_party/android_media MediaController with
android.widget.MediaController

BUG=722688
TEST=manual (cast a video from Chrome and tap on the notification, test the
fullscreen controls)
==========

to

==========
[Cast,Android] Replace custom MediaController with
android.widget.MediaController.

BUG=722688
TEST=manual (cast a video from Chrome and tap on the notification, test the
fullscreen controls)
==========

[dgn, 2017-05-17 16:15:49]

rslgtm

[dgn, 2017-05-17 16:16:06]

lgtm

[whywhat, 2017-05-17 17:09:22]

The CQ bit was checked by avayvod@chromium.org

[whywhat, 2017-05-17 17:09:22]

The patchset sent to the CQ was uploaded after l-g-t-m from thakis@chromium.org
Link to the patchset: https://codereview.chromium.org/2888653002/#ps20001
(title: "Dedented the color in the xml file.")

[whywhat, 2017-05-17 17:09:26]

The CQ bit was unchecked by avayvod@chromium.org

[whywhat, 2017-05-17 17:11:13]

The CQ bit was checked by avayvod@chromium.org

[commit-bot: I haz the power, 2017-05-17 17:12:23]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-17 19:25:40]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-17 19:25:41]

Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[whywhat, 2017-05-17 20:21:33]

The CQ bit was checked by avayvod@chromium.org

[commit-bot: I haz the power, 2017-05-17 20:22:49]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-17 22:11:59]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1495052493548320,
"parent_rev": "834b125e7df0de36eda259f5fe3d49bfadfd197f", "commit_rev":
"41ecb285107a4f13871031481cb865763779d87f"}

[commit-bot: I haz the power, 2017-05-17 22:12:10]

Description was changed from

==========
[Cast,Android] Replace custom MediaController with
android.widget.MediaController.

BUG=722688
TEST=manual (cast a video from Chrome and tap on the notification, test the
fullscreen controls)
==========

to

==========
[Cast,Android] Replace custom MediaController with
android.widget.MediaController.

BUG=722688
TEST=manual (cast a video from Chrome and tap on the notification, test the
fullscreen controls)

Review-Url: https://codereview.chromium.org/2888653002
Cr-Commit-Position: refs/heads/master@{#472583}
Committed:
https://chromium.googlesource.com/chromium/src/+/41ecb285107a4f13871031481cb8...
==========

[commit-bot: I haz the power, 2017-05-17 22:12:11]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/41ecb285107a4f13871031481cb8...

[whywhat, 2017-05-23 21:31:39]

A revert of this CL (patchset #2 id:20001) has been created in
https://codereview.chromium.org/2904683002/ by avayvod@chromium.org.

The reason for reverting is: The CL caused a crash:
https://bugs.chromium.org/p/chromium/issues/detail?id=725028
The revert can't be submitted though as the previous version will break the
build..