Description was changed from ========== [Cast,Android] Replaced sample MediaController with android.widget. one BUG=722688 TEST=manual ========== ...
3 years, 7 months ago
(2017-05-16 19:50:31 UTC)
#6
Description was changed from
==========
[Cast,Android] Replaced sample MediaController with android.widget. one
BUG=722688
TEST=manual
==========
to
==========
[Cast,Android] Replace the third_party/android_media MediaController with
android.widget.MediaController
BUG=722688
TEST=manual (cast a video from Chrome and tap on the notification, test the
fullscreen controls)
==========
whywhat
On 2017/05/16 at 19:13:26, thakis wrote: > "android.widget. one" in CL description looks like a ...
3 years, 7 months ago
(2017-05-16 19:51:23 UTC)
#7
On 2017/05/16 at 19:13:26, thakis wrote:
> "android.widget. one" in CL description looks like a typo.
Changed that to be less confusing.
>
> TEST= is supposed to describe _how_ to manually test things, so that a QA
person could follow the steps listed there.
>
Expanded the description.
> lgtm
>
>
https://codereview.chromium.org/2888653002/diff/1/chrome/android/java/res/val...
> File chrome/android/java/res/values/colors.xml (right):
>
>
https://codereview.chromium.org/2888653002/diff/1/chrome/android/java/res/val...
> chrome/android/java/res/values/colors.xml:219: <color
name="cast_media_controller_text">#bebebe</color>
> dedent by 1
Thanks!
whywhat
https://codereview.chromium.org/2888653002/diff/1/chrome/android/java/res/values/colors.xml File chrome/android/java/res/values/colors.xml (right): https://codereview.chromium.org/2888653002/diff/1/chrome/android/java/res/values/colors.xml#newcode219 chrome/android/java/res/values/colors.xml:219: <color name="cast_media_controller_text">#bebebe</color> On 2017/05/16 at 19:13:26, Nico wrote: > ...
3 years, 7 months ago
(2017-05-16 19:51:28 UTC)
#8
3 years, 7 months ago
(2017-05-16 19:52:15 UTC)
#9
Dedented the color in the xml file.
whywhat
Description was changed from ========== [Cast,Android] Replace the third_party/android_media MediaController with android.widget.MediaController BUG=722688 TEST=manual (cast ...
3 years, 7 months ago
(2017-05-16 20:16:47 UTC)
#10
Description was changed from
==========
[Cast,Android] Replace the third_party/android_media MediaController with
android.widget.MediaController
BUG=722688
TEST=manual (cast a video from Chrome and tap on the notification, test the
fullscreen controls)
==========
to
==========
[Cast,Android] Replace custom MediaController with
android.widget.MediaController.
BUG=722688
TEST=manual (cast a video from Chrome and tap on the notification, test the
fullscreen controls)
==========
dgn
rslgtm
3 years, 7 months ago
(2017-05-17 16:15:49 UTC)
#11
rslgtm
dgn
lgtm
3 years, 7 months ago
(2017-05-17 16:16:06 UTC)
#12
lgtm
whywhat
The CQ bit was checked by avayvod@chromium.org
3 years, 7 months ago
(2017-05-17 17:09:22 UTC)
#13
Try jobs failed on following builders: win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/447350)
3 years, 7 months ago
(2017-05-17 19:25:41 UTC)
#19
CQ is committing da patch. Bot data: {"patchset_id": 20001, "attempt_start_ts": 1495052493548320, "parent_rev": "834b125e7df0de36eda259f5fe3d49bfadfd197f", "commit_rev": "41ecb285107a4f13871031481cb865763779d87f"}
3 years, 7 months ago
(2017-05-17 22:11:59 UTC)
#22
CQ is committing da patch.
Bot data: {"patchset_id": 20001, "attempt_start_ts": 1495052493548320,
"parent_rev": "834b125e7df0de36eda259f5fe3d49bfadfd197f", "commit_rev":
"41ecb285107a4f13871031481cb865763779d87f"}
commit-bot: I haz the power
Description was changed from ========== [Cast,Android] Replace custom MediaController with android.widget.MediaController. BUG=722688 TEST=manual (cast a ...
3 years, 7 months ago
(2017-05-17 22:12:10 UTC)
#23
Message was sent while issue was closed.
Description was changed from
==========
[Cast,Android] Replace custom MediaController with
android.widget.MediaController.
BUG=722688
TEST=manual (cast a video from Chrome and tap on the notification, test the
fullscreen controls)
==========
to
==========
[Cast,Android] Replace custom MediaController with
android.widget.MediaController.
BUG=722688
TEST=manual (cast a video from Chrome and tap on the notification, test the
fullscreen controls)
Review-Url: https://codereview.chromium.org/2888653002
Cr-Commit-Position: refs/heads/master@{#472583}
Committed:
https://chromium.googlesource.com/chromium/src/+/41ecb285107a4f13871031481cb8...
==========
commit-bot: I haz the power
Committed patchset #2 (id:20001) as https://chromium.googlesource.com/chromium/src/+/41ecb285107a4f13871031481cb865763779d87f
3 years, 7 months ago
(2017-05-17 22:12:11 UTC)
#24
Issue 2888653002: [Cast,Android] Replace custom MediaController with android.widget.MediaController.
(Closed)
Created 3 years, 7 months ago by whywhat
Modified 3 years, 7 months ago
Reviewers: dgn, Nico
Base URL:
Comments: 2