Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(266)

Issue 2895263005: [Cast,Android] Remove TransportXX dependency from ExpandedControllerActivity (Closed)

Created:
3 years, 7 months ago by whywhat
Modified:
3 years, 7 months ago
CC:
agrieve+watch_chromium.org, amineer, chromium-reviews, feature-media-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[Cast,Android] Remove TransportXX dependency from ExpandedControllerActivity Since using the default andorid.widget.MediaController causes hard to fix crashes and using MediaSessionCompat required a huge code change, this seems to be the simplest solution, mergeable to 59 if needed. Note that I uploaded this separately from the revert to ease reviewing. BUG=725028 TEST=manual, cast a video and open the activity via the notification.

Patch Set 1 #

Patch Set 2 : Fix lint warnings. #

Patch Set 3 : Replace TransportController and TransportMediator with direct interface #

Patch Set 4 : Updated README.chromium #

Unified diffs Side-by-side diffs Delta from patch set Stats (+104 lines, -107 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/media/remote/ExpandedControllerActivity.java View 1 2 6 chunks +14 lines, -27 lines 0 comments Download
M third_party/android_media/README.chromium View 1 2 3 2 chunks +10 lines, -9 lines 0 comments Download
M third_party/android_media/java/src/org/chromium/third_party/android/media/MediaController.java View 1 2 12 chunks +80 lines, -71 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 14 (7 generated)
whywhat
Nicolas, PTaL Alex, FYI
3 years, 7 months ago (2017-05-22 19:17:27 UTC) #2
whywhat
Fix lint warnings.
3 years, 7 months ago (2017-05-22 19:29:21 UTC) #3
whywhat
Updated README.chromium
3 years, 7 months ago (2017-05-24 00:58:47 UTC) #4
dgn
mlamouri@: would you mind having a look? I'm not familiar with the cast logic anymore. ...
3 years, 7 months ago (2017-05-24 14:13:52 UTC) #11
whywhat
On 2017/05/24 at 14:13:52, dgn wrote: > mlamouri@: would you mind having a look? I'm ...
3 years, 7 months ago (2017-05-26 01:24:09 UTC) #12
dgn
lgtm
3 years, 7 months ago (2017-05-26 09:58:40 UTC) #13
mlamouri (slow - plz ping)
3 years, 7 months ago (2017-05-26 13:27:54 UTC) #14
lgtm

Powered by Google App Engine
This is Rietveld 408576698