Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(388)

Issue 2903183002: [Devtools] Moved preserve log to a setting (Closed)

Created:
3 years, 7 months ago by allada
Modified:
3 years, 7 months ago
Reviewers:
dgozman, pfeldman
CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, pfeldman, kozyatinskiy+blink_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[Devtools] Moved preserve log to a setting Moves preserve log to a setting. This should allow it to be changed in the actions menu and will allow NetworkLog to check the state of preserve log for followup patch to move some functionality into NetworkLog. R=dgozman,pfeldman BUG=None Review-Url: https://codereview.chromium.org/2903183002 Cr-Commit-Position: refs/heads/master@{#474887} Committed: https://chromium.googlesource.com/chromium/src/+/c4c1cb3507777d5bbef9bc09c87571fe4a768e41

Patch Set 1 : [Devtools] Moved preserve log to a setting #

Total comments: 4

Patch Set 2 : changes #

Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -24 lines) Patch
M third_party/WebKit/Source/devtools/front_end/network/NetworkLogView.js View 3 chunks +1 line, -9 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/network/NetworkPanel.js View 4 chunks +6 lines, -15 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/network/module.json View 1 1 chunk +20 lines, -0 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 12 (7 generated)
allada
PTL
3 years, 7 months ago (2017-05-25 01:03:01 UTC) #4
dgozman
lgtm https://codereview.chromium.org/2903183002/diff/60001/third_party/WebKit/Source/devtools/front_end/network/module.json File third_party/WebKit/Source/devtools/front_end/network/module.json (right): https://codereview.chromium.org/2903183002/diff/60001/third_party/WebKit/Source/devtools/front_end/network/module.json#newcode67 third_party/WebKit/Source/devtools/front_end/network/module.json:67: "category": "Network", Make it session setting to preserve ...
3 years, 7 months ago (2017-05-25 23:07:36 UTC) #5
allada
done. https://codereview.chromium.org/2903183002/diff/60001/third_party/WebKit/Source/devtools/front_end/network/module.json File third_party/WebKit/Source/devtools/front_end/network/module.json (right): https://codereview.chromium.org/2903183002/diff/60001/third_party/WebKit/Source/devtools/front_end/network/module.json#newcode67 third_party/WebKit/Source/devtools/front_end/network/module.json:67: "category": "Network", On 2017/05/25 23:07:36, dgozman wrote: > ...
3 years, 7 months ago (2017-05-26 00:04:00 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2903183002/80001
3 years, 7 months ago (2017-05-26 00:04:32 UTC) #9
commit-bot: I haz the power
3 years, 7 months ago (2017-05-26 02:44:47 UTC) #12
Message was sent while issue was closed.
Committed patchset #2 (id:80001) as
https://chromium.googlesource.com/chromium/src/+/c4c1cb3507777d5bbef9bc09c875...

Powered by Google App Engine
This is Rietveld 408576698