Chromium Code Reviews Chromium Code Reviews
Issue 2903183002:
[Devtools] Moved preserve log to a setting (Closed)
| OLD | NEW |
|---|---|
| 1 { | 1 { |
| 2 "extensions": [ | 2 "extensions": [ |
| 3 { | 3 { |
| 4 "type": "view", | 4 "type": "view", |
| 5 "location": "panel", | 5 "location": "panel", |
| 6 "id": "network", | 6 "id": "network", |
| 7 "title": "Network", | 7 "title": "Network", |
| 8 "order": 40, | 8 "order": 40, |
| 9 "className": "Network.NetworkPanel" | 9 "className": "Network.NetworkPanel" |
| 10 }, | 10 }, |
| (...skipping 45 matching lines...) Expand 10 before | Expand all | Expand 10 after Loading... | |
| 56 "value": true, | 56 "value": true, |
| 57 "title": "Group network log items by frame" | 57 "title": "Group network log items by frame" |
| 58 }, | 58 }, |
| 59 { | 59 { |
| 60 "value": false, | 60 "value": false, |
| 61 "title": "Don't group network log items by frame" | 61 "title": "Don't group network log items by frame" |
| 62 } | 62 } |
| 63 ] | 63 ] |
| 64 }, | 64 }, |
| 65 { | 65 { |
| 66 "type": "setting", | |
| 67 "category": "Network", | |
|
dgozman
2017/05/25 23:07:36
Make it session setting to preserve current behavi
allada
2017/05/26 00:04:00
Done.
| |
| 68 "title": "Preserve log", | |
| 69 "settingName": "network.preserve-log", | |
| 70 "settingType": "boolean", | |
| 71 "defaultValue": false, | |
| 72 "tags": "network, preserve, clear, reset, log", | |
|
dgozman
2017/05/25 23:07:36
No need to repeat words from description (preserve
allada
2017/05/26 00:04:00
Done.
| |
| 73 "options": [ | |
| 74 { | |
| 75 "value": true, | |
| 76 "title": "Do not preserve log on page reload / navigation" | |
| 77 }, | |
| 78 { | |
| 79 "value": false, | |
| 80 "title": "Preserve log on page reload / navigation" | |
| 81 } | |
| 82 ] | |
| 83 }, | |
| 84 { | |
| 66 "type": "@UI.ActionDelegate", | 85 "type": "@UI.ActionDelegate", |
| 67 "actionId": "network.toggle-recording", | 86 "actionId": "network.toggle-recording", |
| 68 "iconClass": "largeicon-start-recording", | 87 "iconClass": "largeicon-start-recording", |
| 69 "toggledIconClass": "largeicon-stop-recording", | 88 "toggledIconClass": "largeicon-stop-recording", |
| 70 "toggleWithRedColor": true, | 89 "toggleWithRedColor": true, |
| 71 "contextTypes": [ | 90 "contextTypes": [ |
| 72 "Network.NetworkPanel" | 91 "Network.NetworkPanel" |
| 73 ], | 92 ], |
| 74 "className": "Network.NetworkPanel.RecordActionDelegate", | 93 "className": "Network.NetworkPanel.RecordActionDelegate", |
| 75 "options": [ | 94 "options": [ |
| (...skipping 85 matching lines...) Expand 10 before | Expand all | Expand 10 after Loading... | |
| 161 "networkTimingTable.css", | 180 "networkTimingTable.css", |
| 162 "networkWaterfallColumn.css", | 181 "networkWaterfallColumn.css", |
| 163 "requestCookiesView.css", | 182 "requestCookiesView.css", |
| 164 "requestHeadersTree.css", | 183 "requestHeadersTree.css", |
| 165 "requestHeadersView.css", | 184 "requestHeadersView.css", |
| 166 "webSocketFrameView.css", | 185 "webSocketFrameView.css", |
| 167 "xmlTree.css", | 186 "xmlTree.css", |
| 168 "xmlView.css" | 187 "xmlView.css" |
| 169 ] | 188 ] |
| 170 } | 189 } |
| OLD | NEW |
