[Devtools] Move to canReplayRequest in NetworkRequest

[Devtools] Move to canReplayRequest in NetworkRequest

This patch is in preporation to break target dependency in
NetworkRequest. This specific patch is because we will be adding more
conditions in canReplayRequest().

R=dgozman,pfeldman
BUG=None

Review-Url: https://codereview.chromium.org/2906843002
Cr-Commit-Position: refs/heads/master@{#476466}
Committed: https://chromium.googlesource.com/chromium/src/+/3d5ca99fe1815a936278f4952f7e4497dc2bbaaa

[allada, 2017-05-25 23:59:50]

PTL

[allada, 2017-05-26 00:05:36]

Patchset #1 (id:1) has been deleted

[dgozman, 2017-05-26 19:11:28]

lgtm

[pfeldman, 2017-05-30 17:39:45]

https://codereview.chromium.org/2906843002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/devtools/front_end/sdk/NetworkRequest.js (right):

https://codereview.chromium.org/2906843002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/sdk/NetworkRequest.js:1114:
canReplayRequest() {
I thought that it would move to the network manager, why not put it there right
away?

[allada, 2017-05-31 23:30:13]

PTaL @ pfeldman

https://codereview.chromium.org/2906843002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/devtools/front_end/sdk/NetworkRequest.js (right):

https://codereview.chromium.org/2906843002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/sdk/NetworkRequest.js:1114:
canReplayRequest() {
On 2017/05/30 17:39:45, pfeldman wrote:
> I thought that it would move to the network manager, why not put it there
right
> away?

I was going to move this after I remove the reference to which networkManager
the request belongs to in the NetworkRequest itself.

[pfeldman, 2017-05-31 23:35:56]

lgtm

[allada, 2017-05-31 23:44:31]

The CQ bit was checked by allada@chromium.org

[allada, 2017-05-31 23:44:31]

The patchset sent to the CQ was uploaded after l-g-t-m from dgozman@chromium.org
Link to the patchset: https://codereview.chromium.org/2906843002/#ps40001
(title: "moved replayRequest stuff to networkManager")

[commit-bot: I haz the power, 2017-05-31 23:45:04]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[allada, 2017-06-01 01:31:19]

The CQ bit was unchecked by allada@chromium.org

[allada, 2017-06-01 20:41:15]

The CQ bit was checked by allada@chromium.org

[allada, 2017-06-01 20:41:16]

The patchset sent to the CQ was uploaded after l-g-t-m from
dgozman@chromium.org, pfeldman@chromium.org
Link to the patchset: https://codereview.chromium.org/2906843002/#ps60001
(title: "changes")

[commit-bot: I haz the power, 2017-06-01 20:41:56]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-01 22:52:37]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1496349675893470,
"parent_rev": "4b31acdd37eb70ad84fbd68a03ee2e66acb93f99", "commit_rev":
"3d5ca99fe1815a936278f4952f7e4497dc2bbaaa"}

[commit-bot: I haz the power, 2017-06-01 22:52:49]

Description was changed from

==========
[Devtools] Move to canReplayRequest in NetworkRequest

This patch is in preporation to break target dependency in
NetworkRequest. This specific patch is because we will be adding more
conditions in canReplayRequest().

R=dgozman,pfeldman
BUG=None
==========

to

==========
[Devtools] Move to canReplayRequest in NetworkRequest

This patch is in preporation to break target dependency in
NetworkRequest. This specific patch is because we will be adding more
conditions in canReplayRequest().

R=dgozman,pfeldman
BUG=None

Review-Url: https://codereview.chromium.org/2906843002
Cr-Commit-Position: refs/heads/master@{#476466}
Committed:
https://chromium.googlesource.com/chromium/src/+/3d5ca99fe1815a936278f4952f7e...
==========

[commit-bot: I haz the power, 2017-06-01 22:52:50]

Committed patchset #3 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/3d5ca99fe1815a936278f4952f7e...