Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(716)

Unified Diff: third_party/WebKit/Source/devtools/front_end/network/NetworkLogView.js

Issue 2903183002: [Devtools] Moved preserve log to a setting (Closed)
Patch Set: changes Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | third_party/WebKit/Source/devtools/front_end/network/NetworkPanel.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/devtools/front_end/network/NetworkLogView.js
diff --git a/third_party/WebKit/Source/devtools/front_end/network/NetworkLogView.js b/third_party/WebKit/Source/devtools/front_end/network/NetworkLogView.js
index 7ac42e16eb26bad137c1013395f98fd72acdbe4d..7fbfb92c438f9b55fa76693edf4c336412657a27 100644
--- a/third_party/WebKit/Source/devtools/front_end/network/NetworkLogView.js
+++ b/third_party/WebKit/Source/devtools/front_end/network/NetworkLogView.js
@@ -96,7 +96,6 @@ Network.NetworkLogView = class extends UI.VBox {
this.badgePool = new ProductRegistry.BadgePool();
this._recording = false;
- this._preserveLog = false;
this._headerHeight = 0;
@@ -399,13 +398,6 @@ Network.NetworkLogView = class extends UI.VBox {
}
/**
- * @param {boolean} preserveLog
- */
- setPreserveLog(preserveLog) {
- this._preserveLog = preserveLog;
- }
-
- /**
* @override
* @param {!SDK.NetworkManager} networkManager
*/
@@ -1070,7 +1062,7 @@ Network.NetworkLogView = class extends UI.VBox {
requestsToPick.push(request);
}
- if (!this._preserveLog) {
+ if (!Common.moduleSetting('network.preserve-log').get()) {
this.reset();
for (var i = 0; i < requestsToPick.length; ++i)
this._appendRequest(requestsToPick[i]);
« no previous file with comments | « no previous file | third_party/WebKit/Source/devtools/front_end/network/NetworkPanel.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698