DevTools: shorten console links to 40 chars

DevTools: shorten console links to 40 chars

This CL affects anchors, stack trace links, and internal#locations in
ObjectPropertiesSection inside Console.

Please see bug for screenshots.

BUG=726023
Review-Url: https://codereview.chromium.org/2903083002
Cr-Commit-Position: refs/heads/master@{#475645}
Committed: https://chromium.googlesource.com/chromium/src/+/4bfa586a0b0ca582e7fe9b6cb552937681280600

[luoe, 2017-05-24 19:12:52]

Description was changed from

==========
DevTools: shorten console links to 40 chars

BUG=726023
==========

to

==========
DevTools: shorten console links to 40 chars

Please see bug for screenshots.

BUG=726023
==========

[luoe, 2017-05-24 19:15:13]

Description was changed from

==========
DevTools: shorten console links to 40 chars

Please see bug for screenshots.

BUG=726023
==========

to

==========
DevTools: shorten console links to 40 chars

This CL affects anchors, stack trace links, and internal#locations in
ObjectPropertiesSection inside Console.

Please see bug for screenshots.

BUG=726023
==========

[luoe, 2017-05-24 19:15:25]

luoe@chromium.org changed reviewers:
+ pfeldman@chromium.org

[luoe, 2017-05-24 19:15:26]

Please take a look

[pfeldman, 2017-05-24 20:16:29]

https://codereview.chromium.org/2903083002/diff/1/third_party/WebKit/Source/d...
File third_party/WebKit/Source/devtools/front_end/components/Linkifier.js
(right):

https://codereview.chromium.org/2903083002/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/components/Linkifier.js:335: static
linkifyURL(url, text, className, lineNumber, columnNumber, preventClick,
maxLength) {
Do you know who uses prevent click? Maybe it is time to go for the "options"
param with named properties for all the optional params?

[luoe, 2017-05-24 21:58:25]

https://codereview.chromium.org/2903083002/diff/1/third_party/WebKit/Source/d...
File third_party/WebKit/Source/devtools/front_end/components/Linkifier.js
(right):

https://codereview.chromium.org/2903083002/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/components/Linkifier.js:335: static
linkifyURL(url, text, className, lineNumber, columnNumber, preventClick,
maxLength) {
On 2017/05/24 20:16:29, pfeldman wrote:
> Do you know who uses prevent click? Maybe it is time to go for the "options"
> param with named properties for all the optional params?

Only Elements' tree outline and SSP have links that don't open when you click
them.  Param was added here: https://codereview.chromium.org/2519213002

Options object sounds good to me.  That change seems to overshadow this CL's
update to console's linkifier, so I've made a followup CL for it
https://codereview.chromium.org/2902273002/

Lemme know if you'd rather merge it into this CL.

[pfeldman, 2017-05-30 18:09:32]

lgtm

[luoe, 2017-05-30 18:09:59]

The CQ bit was checked by luoe@chromium.org

[commit-bot: I haz the power, 2017-05-30 18:11:06]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-30 20:11:20]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1496167799568000, "parent_rev":
"8d702339698fb0f317fcc4e594d91007c47b25f0", "commit_rev":
"4bfa586a0b0ca582e7fe9b6cb552937681280600"}

[commit-bot: I haz the power, 2017-05-30 20:11:30]

Description was changed from

==========
DevTools: shorten console links to 40 chars

This CL affects anchors, stack trace links, and internal#locations in
ObjectPropertiesSection inside Console.

Please see bug for screenshots.

BUG=726023
==========

to

==========
DevTools: shorten console links to 40 chars

This CL affects anchors, stack trace links, and internal#locations in
ObjectPropertiesSection inside Console.

Please see bug for screenshots.

BUG=726023

Review-Url: https://codereview.chromium.org/2903083002
Cr-Commit-Position: refs/heads/master@{#475645}
Committed:
https://chromium.googlesource.com/chromium/src/+/4bfa586a0b0ca582e7fe9b6cb552...
==========

[commit-bot: I haz the power, 2017-05-30 20:11:33]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/4bfa586a0b0ca582e7fe9b6cb552...