DevTools: shorten console links to 40 chars

third_party/WebKit/Source/devtools/front_end/components/Linkifier.js

Index: third_party/WebKit/Source/devtools/front_end/components/Linkifier.js
diff --git a/third_party/WebKit/Source/devtools/front_end/components/Linkifier.js b/third_party/WebKit/Source/devtools/front_end/components/Linkifier.js
index 254f618605c27444349e5949592677e07f5945c9..b72baa3c79f0c14f754ce789260a77deadbe0b0d 100644
--- a/third_party/WebKit/Source/devtools/front_end/components/Linkifier.js
+++ b/third_party/WebKit/Source/devtools/front_end/components/Linkifier.js
@@ -149,8 +149,10 @@ Components.Linkifier = class {
    * @return {?Element}
    */
   maybeLinkifyScriptLocation(target, scriptId, sourceURL, lineNumber, columnNumber, classes) {
-    var fallbackAnchor =
-        sourceURL ? Components.Linkifier.linkifyURL(sourceURL, undefined, classes, lineNumber, columnNumber) : null;
+    var fallbackAnchor = sourceURL ?
+        Components.Linkifier.linkifyURL(
+            sourceURL, undefined, classes, lineNumber, columnNumber, undefined, this._maxLength) :
+        null;
     if (!target || target.isDisposed())
       return fallbackAnchor;
     var debuggerModel = target.model(SDK.DebuggerModel);
@@ -187,7 +189,8 @@ Components.Linkifier = class {
    */
   linkifyScriptLocation(target, scriptId, sourceURL, lineNumber, columnNumber, classes) {
     return this.maybeLinkifyScriptLocation(target, scriptId, sourceURL, lineNumber, columnNumber, classes) ||
-        Components.Linkifier.linkifyURL(sourceURL, undefined, classes, lineNumber, columnNumber);
+        Components.Linkifier.linkifyURL(
+            sourceURL, undefined, classes, lineNumber, columnNumber, undefined, this._maxLength);
   }
 
   /**
@@ -223,8 +226,8 @@ Components.Linkifier = class {
     console.assert(stackTrace.callFrames && stackTrace.callFrames.length);
 
     var topFrame = stackTrace.callFrames[0];
-    var fallbackAnchor =
-        Components.Linkifier.linkifyURL(topFrame.url, undefined, classes, topFrame.lineNumber, topFrame.columnNumber);
+    var fallbackAnchor = Components.Linkifier.linkifyURL(
+        topFrame.url, undefined, classes, topFrame.lineNumber, topFrame.columnNumber, undefined, this._maxLength);
     if (target.isDisposed())
       return fallbackAnchor;
 
@@ -326,9 +329,10 @@ Components.Linkifier = class {
    * @param {number=} lineNumber
    * @param {number=} columnNumber
    * @param {boolean=} preventClick
+   * @param {number=} maxLength
    * @return {!Element}
    */
-  static linkifyURL(url, text, className, lineNumber, columnNumber, preventClick) {
+  static linkifyURL(url, text, className, lineNumber, columnNumber, preventClick, maxLength) {

[pfeldman, 2017/05/24 20:16:29]

Do you know who uses prevent click? Maybe it is time to go for the "options"
param with named properties for all the optional params?

[luoe, 2017/05/24 21:58:25]

Only Elements' tree outline and SSP have links that don't open when you click
them.  Param was added here: https://codereview.chromium.org/2519213002

Options object sounds good to me.  That change seems to overshadow this CL's
update to console's linkifier, so I've made a followup CL for it
https://codereview.chromium.org/2902273002/

Lemme know if you'd rather merge it into this CL.

     if (!url || url.trim().toLowerCase().startsWith('javascript:')) {
       var element = createElementWithClass('span', className);
       element.textContent = text || url || Common.UIString('(unknown)');
@@ -340,7 +344,7 @@ Components.Linkifier = class {
       linkText += ':' + (lineNumber + 1);
     var title = linkText !== url ? url : '';
     var link = Components.Linkifier._createLink(
-        linkText, className || '', UI.MaxLengthForDisplayedURLs, title, url, preventClick);
+        linkText, className || '', maxLength || UI.MaxLengthForDisplayedURLs, title, url, preventClick);
     var info = Components.Linkifier._linkInfo(link);
     if (typeof lineNumber === 'number')
       info.lineNumber = lineNumber;