[DevTools] Remove preventFollow and special checks for links throughout frontend.

[DevTools] Remove preventFollow and special checks for links throughout frontend.

Previously, we handled links using click handler on document, so many places
had to be careful to not intercept clicks on links.
Now links have their own click handler so we can remove those check.

Also, different context menu handlers should have been aware to call appendApplicableItems for
target node. Now it's done automatically in ContextMenu constructor, which handles it for everyone.

BUG=665661
Committed: https://crrev.com/411a262c8298a3f9acd8db3f9650067a0a984d54
Cr-Commit-Position: refs/heads/master@{#434113}

[dgozman, 2016-11-22 00:37:02]

dgozman@chromium.org changed reviewers:
+ lushnikov@chromium.org

[dgozman, 2016-11-22 00:37:03]

Take a look please.

[lushnikov, 2016-11-22 01:11:49]

https://codereview.chromium.org/2519213002/diff/1/third_party/WebKit/Source/d...
File
third_party/WebKit/Source/devtools/front_end/elements/ElementsTreeOutline.js
(left):

https://codereview.chromium.org/2519213002/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/elements/ElementsTreeOutline.js:788:
contextMenu.appendApplicableItems(event.target);
why is this gone?

https://codereview.chromium.org/2519213002/diff/1/third_party/WebKit/Source/d...
File third_party/WebKit/Source/devtools/front_end/ui/ContextMenu.js (right):

https://codereview.chromium.org/2519213002/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/ui/ContextMenu.js:304:
this.appendApplicableItems(/** @type {!Object} */ (target));
won't this result in double-applicable-items? You already appended them in the
installHandler callback

[dgozman, 2016-11-22 01:33:14]

Description was changed from

==========
[DevTools] Remove preventFollow and special checks for links throughout
frontend.

Previously, we handled links using click handler on document, so many places
had to be careful to not intercept clicks on links.

Now links have their own click handler so we can remove those check.

BUG=665661
==========

to

==========
[DevTools] Remove preventFollow and special checks for links throughout
frontend.

Previously, we handled links using click handler on document, so many places
had to be careful to not intercept clicks on links.
Now links have their own click handler so we can remove those check.

Also, different context menu handlers should have been aware to call
appendApplicableItems for
target node. Now it's done automatically in ContextMenu constructor, which
handles it for everyone.

BUG=665661
==========

[dgozman, 2016-11-22 01:33:19]

https://codereview.chromium.org/2519213002/diff/1/third_party/WebKit/Source/d...
File
third_party/WebKit/Source/devtools/front_end/elements/ElementsTreeOutline.js
(left):

https://codereview.chromium.org/2519213002/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/elements/ElementsTreeOutline.js:788:
contextMenu.appendApplicableItems(event.target);
On 2016/11/22 01:11:49, lushnikov wrote:
> why is this gone?

It's now done automatically in ContextMenu constructor. I'll update patch
description.

https://codereview.chromium.org/2519213002/diff/1/third_party/WebKit/Source/d...
File third_party/WebKit/Source/devtools/front_end/ui/ContextMenu.js (right):

https://codereview.chromium.org/2519213002/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/ui/ContextMenu.js:304:
this.appendApplicableItems(/** @type {!Object} */ (target));
On 2016/11/22 01:11:49, lushnikov wrote:
> won't this result in double-applicable-items? You already appended them in the
> installHandler callback

I did actually remove them from installHandler callback.

[lushnikov, 2016-11-22 01:50:22]

lgtm

[dgozman, 2016-11-23 02:04:49]

The CQ bit was checked by dgozman@chromium.org

[commit-bot: I haz the power, 2016-11-23 02:05:23]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-23 04:16:35]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1479866689648380, "parent_rev":
"6444642eb0590cbf2effd14b41810ff4c8aae1a4", "commit_rev":
"9b42e8dcd7b3f87467d21fe40f189388de2f653f"}

[commit-bot: I haz the power, 2016-11-23 04:17:17]

Description was changed from

==========
[DevTools] Remove preventFollow and special checks for links throughout
frontend.

Previously, we handled links using click handler on document, so many places
had to be careful to not intercept clicks on links.
Now links have their own click handler so we can remove those check.

Also, different context menu handlers should have been aware to call
appendApplicableItems for
target node. Now it's done automatically in ContextMenu constructor, which
handles it for everyone.

BUG=665661
==========

to

==========
[DevTools] Remove preventFollow and special checks for links throughout
frontend.

Previously, we handled links using click handler on document, so many places
had to be careful to not intercept clicks on links.
Now links have their own click handler so we can remove those check.

Also, different context menu handlers should have been aware to call
appendApplicableItems for
target node. Now it's done automatically in ContextMenu constructor, which
handles it for everyone.

BUG=665661
==========

[commit-bot: I haz the power, 2016-11-23 04:17:18]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-11-23 04:19:37]

Description was changed from

==========
[DevTools] Remove preventFollow and special checks for links throughout
frontend.

Previously, we handled links using click handler on document, so many places
had to be careful to not intercept clicks on links.
Now links have their own click handler so we can remove those check.

Also, different context menu handlers should have been aware to call
appendApplicableItems for
target node. Now it's done automatically in ContextMenu constructor, which
handles it for everyone.

BUG=665661
==========

to

==========
[DevTools] Remove preventFollow and special checks for links throughout
frontend.

Previously, we handled links using click handler on document, so many places
had to be careful to not intercept clicks on links.
Now links have their own click handler so we can remove those check.

Also, different context menu handlers should have been aware to call
appendApplicableItems for
target node. Now it's done automatically in ContextMenu constructor, which
handles it for everyone.

BUG=665661

Committed: https://crrev.com/411a262c8298a3f9acd8db3f9650067a0a984d54
Cr-Commit-Position: refs/heads/master@{#434113}
==========

[commit-bot: I haz the power, 2016-11-23 04:19:38]

Patchset 1 (id:??) landed as
https://crrev.com/411a262c8298a3f9acd8db3f9650067a0a984d54
Cr-Commit-Position: refs/heads/master@{#434113}