DevTools: convert linkifyURL params into options object

DevTools: convert linkifyURL params into options object

Seven parameters in linkifyURL() is a bit much.

BUG=none

Review-Url: https://codereview.chromium.org/2902273002
Cr-Commit-Position: refs/heads/master@{#476861}
Committed: https://chromium.googlesource.com/chromium/src/+/e4cbc43409cdddb63d97beb203a497bad5a17d00

[luoe, 2017-05-24 21:58:04]

Description was changed from

==========
DevTools: convert linkifyURL params into options object

BUG=none
==========

to

==========
DevTools: convert linkifyURL params into options object

Seven parameters in linkifyURL() is a bit much.

BUG=none
==========

[luoe, 2017-05-24 21:58:45]

luoe@chromium.org changed reviewers:
+ pfeldman@chromium.org

[luoe, 2017-05-24 21:58:45]

Ptal, this depends on https://codereview.chromium.org/2903083002/

[pfeldman, 2017-05-31 21:54:59]

https://codereview.chromium.org/2902273002/diff/1/third_party/WebKit/Source/d...
File third_party/WebKit/Source/devtools/front_end/components/Linkifier.js
(right):

https://codereview.chromium.org/2902273002/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/components/Linkifier.js:345: static
linkifyURL(options) {
In my original review, I was suggesting to only convert optional parameters to
options, retaining the url itself. You'll see how much more readable the code
would be!

[luoe, 2017-06-02 18:21:12]

Ptal

https://codereview.chromium.org/2902273002/diff/1/third_party/WebKit/Source/d...
File third_party/WebKit/Source/devtools/front_end/components/Linkifier.js
(right):

https://codereview.chromium.org/2902273002/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/components/Linkifier.js:345: static
linkifyURL(options) {
On 2017/05/31 21:54:59, pfeldman wrote:
> In my original review, I was suggesting to only convert optional parameters to
> options, retaining the url itself. You'll see how much more readable the code
> would be!

I see.  Looks better to me!

[pfeldman, 2017-06-02 18:39:41]

lgtm

[luoe, 2017-06-02 18:40:14]

The CQ bit was checked by luoe@chromium.org

[commit-bot: I haz the power, 2017-06-02 18:41:01]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-02 23:18:24]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-02 23:18:26]

Try jobs failed on following builders:
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[luoe, 2017-06-02 23:22:30]

The CQ bit was checked by luoe@chromium.org

[commit-bot: I haz the power, 2017-06-02 23:23:05]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-03 02:20:05]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1496445750250900,
"parent_rev": "b10e64f7403ca1fa46a53d1eb95cb3cd6a5d39c1", "commit_rev":
"e4cbc43409cdddb63d97beb203a497bad5a17d00"}

[commit-bot: I haz the power, 2017-06-03 02:20:14]

Description was changed from

==========
DevTools: convert linkifyURL params into options object

Seven parameters in linkifyURL() is a bit much.

BUG=none
==========

to

==========
DevTools: convert linkifyURL params into options object

Seven parameters in linkifyURL() is a bit much.

BUG=none

Review-Url: https://codereview.chromium.org/2902273002
Cr-Commit-Position: refs/heads/master@{#476861}
Committed:
https://chromium.googlesource.com/chromium/src/+/e4cbc43409cdddb63d97beb203a4...
==========

[commit-bot: I haz the power, 2017-06-03 02:20:15]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/e4cbc43409cdddb63d97beb203a4...