third_party/WebKit/Source/devtools/front_end/network/NetworkDataGridNode.js - Issue 2902273002: DevTools: convert linkifyURL params into options object

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/devtools/front_end/network/NetworkDataGridNode.js

Issue 2902273002: DevTools: convert linkifyURL params into options object (Closed)

Patch Set: rebase and ac Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/devtools/front_end/elements/StylesSidebarPane.js ('k') | third_party/WebKit/Source/devtools/front_end/resources/AppManifestView.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/devtools/front_end/network/NetworkDataGridNode.js

diff --git a/third_party/WebKit/Source/devtools/front_end/network/NetworkDataGridNode.js b/third_party/WebKit/Source/devtools/front_end/network/NetworkDataGridNode.js

index 659c86b853a5c31bf84f5fd32498d35bee5923f3..e8cd7800b00edc4256a3c06287bcf973817d7751 100644

--- a/third_party/WebKit/Source/devtools/front_end/network/NetworkDataGridNode.js

+++ b/third_party/WebKit/Source/devtools/front_end/network/NetworkDataGridNode.js

@@ -929,9 +929,11 @@ Network.NetworkRequestNode = class extends Network.NetworkNode {

case SDK.NetworkRequest.InitiatorType.Parser:

cell.title = initiator.url + ':' + (initiator.lineNumber + 1);

var uiSourceCode = Workspace.workspace.uiSourceCodeForURL(initiator.url);

- cell.appendChild(Components.Linkifier.linkifyURL(

- initiator.url, uiSourceCode ? uiSourceCode.displayName() : undefined, '', initiator.lineNumber,

- initiator.columnNumber));

+ cell.appendChild(Components.Linkifier.linkifyURL(initiator.url, {

+ text: uiSourceCode ? uiSourceCode.displayName() : undefined,

+ lineNumber: initiator.lineNumber,

+ columnNumber: initiator.columnNumber

+ }));

this._appendSubtitle(cell, Common.UIString('Parser'));

break;