third_party/WebKit/Source/devtools/front_end/resources/AppManifestView.js - Issue 2902273002: DevTools: convert linkifyURL params into options object

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/devtools/front_end/resources/AppManifestView.js

Issue 2902273002: DevTools: convert linkifyURL params into options object (Closed)

Patch Set: rebase and ac Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/devtools/front_end/network/NetworkDataGridNode.js ('k') | third_party/WebKit/Source/devtools/front_end/resources/ServiceWorkersView.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/devtools/front_end/resources/AppManifestView.js

diff --git a/third_party/WebKit/Source/devtools/front_end/resources/AppManifestView.js b/third_party/WebKit/Source/devtools/front_end/resources/AppManifestView.js

index 2354b93bb8ac1c9372217fea7050c953c3e7949b..9b8dc4f28d29871382fd46694e14e9b4d1baac45 100644

--- a/third_party/WebKit/Source/devtools/front_end/resources/AppManifestView.js

+++ b/third_party/WebKit/Source/devtools/front_end/resources/AppManifestView.js

@@ -115,8 +115,8 @@ Resources.AppManifestView = class extends UI.VBox {

this._startURLField.removeChildren();

var startURL = stringProperty('start_url');

if (startURL) {

- this._startURLField.appendChild(Components.Linkifier.linkifyURL(

- /** @type {string} */ (Common.ParsedURL.completeURL(url, startURL)), startURL));

+ var completeURL = /** @type {string} */ (Common.ParsedURL.completeURL(url, startURL));

+ this._startURLField.appendChild(Components.Linkifier.linkifyURL(completeURL, {text: startURL}));

}

this._themeColorSwatch.classList.toggle('hidden', !stringProperty('theme_color'));