Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(363)

Issue 2901383008: [Extenisons Bindings] Support `unmanaged` property for events (Closed)

Created:
3 years, 7 months ago by Devlin
Modified:
3 years, 6 months ago
Reviewers:
lazyboy, jbroman
CC:
chromium-apps-reviews_chromium.org, chromium-reviews, extensions-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[Extenisons Bindings] Support `unmanaged` property for events A few events (like chrome.runtime.sendMessage and related events) are specified as `unmanaged`, meaning that the browser does not have to track the listeners (similar to anonymous events). Add support for these in native bindings. Add tests for the same. BUG=653596 Review-Url: https://codereview.chromium.org/2901383008 Cr-Commit-Position: refs/heads/master@{#476046} Committed: https://chromium.googlesource.com/chromium/src/+/fb9bbbcec682d33356ae79cf42809d3926f59c39

Patch Set 1 #

Patch Set 2 : . #

Patch Set 3 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+119 lines, -24 lines) Patch
M extensions/renderer/api_binding.cc View 1 2 6 chunks +12 lines, -3 lines 0 comments Download
M extensions/renderer/api_binding_js_util.cc View 1 1 chunk +4 lines, -2 lines 0 comments Download
M extensions/renderer/api_event_handler.h View 1 1 chunk +3 lines, -1 line 0 comments Download
M extensions/renderer/api_event_handler.cc View 2 chunks +3 lines, -1 line 0 comments Download
M extensions/renderer/api_event_handler_unittest.cc View 13 chunks +66 lines, -16 lines 0 comments Download
M extensions/renderer/chrome_setting.cc View 1 chunk +1 line, -1 line 0 comments Download
M extensions/renderer/native_extension_bindings_system_unittest.cc View 1 2 1 chunk +30 lines, -0 lines 0 comments Download

Messages

Total messages: 17 (12 generated)
Devlin
Heya folks, mind taking a look?
3 years, 6 months ago (2017-05-31 01:43:02 UTC) #10
jbroman
lgtm
3 years, 6 months ago (2017-05-31 20:20:42 UTC) #11
lazyboy
lgtm
3 years, 6 months ago (2017-05-31 21:28:25 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2901383008/40001
3 years, 6 months ago (2017-05-31 21:41:00 UTC) #14
commit-bot: I haz the power
3 years, 6 months ago (2017-05-31 21:50:58 UTC) #17
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/fb9bbbcec682d33356ae79cf4280...

Powered by Google App Engine
This is Rietveld 408576698