Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(583)

Unified Diff: extensions/renderer/api_binding_js_util.cc

Issue 2901383008: [Extenisons Bindings] Support `unmanaged` property for events (Closed)
Patch Set: rebase Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « extensions/renderer/api_binding.cc ('k') | extensions/renderer/api_event_handler.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: extensions/renderer/api_binding_js_util.cc
diff --git a/extensions/renderer/api_binding_js_util.cc b/extensions/renderer/api_binding_js_util.cc
index c5fd2ba9a823b204d975b7f1364138cd9fbb05bb..1f84df277dfb2bda2c6c386054afad6571cd099f 100644
--- a/extensions/renderer/api_binding_js_util.cc
+++ b/extensions/renderer/api_binding_js_util.cc
@@ -128,8 +128,10 @@ void APIBindingJSUtil::CreateCustomEvent(gin::Arguments* arguments,
if (event_name.empty()) {
event = event_handler_->CreateAnonymousEventInstance(context);
} else {
- event = event_handler_->CreateEventInstance(
- event_name, supports_filters, binding::kNoListenerMax, context);
+ bool notify_on_change = true;
+ event = event_handler_->CreateEventInstance(event_name, supports_filters,
+ binding::kNoListenerMax,
+ notify_on_change, context);
}
arguments->Return(event);
« no previous file with comments | « extensions/renderer/api_binding.cc ('k') | extensions/renderer/api_event_handler.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698