Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(180)

Unified Diff: extensions/renderer/chrome_setting.cc

Issue 2901383008: [Extenisons Bindings] Support `unmanaged` property for events (Closed)
Patch Set: rebase Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: extensions/renderer/chrome_setting.cc
diff --git a/extensions/renderer/chrome_setting.cc b/extensions/renderer/chrome_setting.cc
index 4753dbe3e77747bf6d98fa6369fa6312e367022b..2509bfbb593fceac992cc988054799690e07061d 100644
--- a/extensions/renderer/chrome_setting.cc
+++ b/extensions/renderer/chrome_setting.cc
@@ -116,7 +116,7 @@ v8::Local<v8::Value> ChromeSetting::GetOnChangeEvent(
event = event_handler_->CreateEventInstance(
base::StringPrintf("types.ChromeSetting.%s.onChange",
pref_name_.c_str()),
- supports_filters, binding::kNoListenerMax, context);
+ supports_filters, binding::kNoListenerMax, true, context);
v8::Maybe<bool> set_result = wrapper->SetPrivate(context, key, event);
if (!set_result.IsJust() || !set_result.FromJust()) {
NOTREACHED();
« no previous file with comments | « extensions/renderer/api_event_handler_unittest.cc ('k') | extensions/renderer/native_extension_bindings_system_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698