Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1722)

Unified Diff: extensions/renderer/api_event_handler.cc

Issue 2901383008: [Extenisons Bindings] Support `unmanaged` property for events (Closed)
Patch Set: rebase Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « extensions/renderer/api_event_handler.h ('k') | extensions/renderer/api_event_handler_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: extensions/renderer/api_event_handler.cc
diff --git a/extensions/renderer/api_event_handler.cc b/extensions/renderer/api_event_handler.cc
index fc8c3a1a25119d12c11094715aa147751bf4df16..7c37c60d6cd0a93a64d48f84f3a0f1ef7ed883e4 100644
--- a/extensions/renderer/api_event_handler.cc
+++ b/extensions/renderer/api_event_handler.cc
@@ -116,6 +116,7 @@ v8::Local<v8::Object> APIEventHandler::CreateEventInstance(
const std::string& event_name,
bool supports_filters,
int max_listeners,
+ bool notify_on_change,
v8::Local<v8::Context> context) {
// We need a context scope since gin::CreateHandle only takes the isolate
// and infers the context from that.
@@ -127,7 +128,8 @@ v8::Local<v8::Object> APIEventHandler::CreateEventInstance(
DCHECK(data->emitters.find(event_name) == data->emitters.end());
APIEventListeners::ListenersUpdated updated =
- base::Bind(listeners_changed_, event_name);
+ notify_on_change ? base::Bind(listeners_changed_, event_name)
+ : base::Bind(&DoNothingOnListenersChanged);
std::unique_ptr<APIEventListeners> listeners;
if (supports_filters) {
listeners = base::MakeUnique<FilteredEventListeners>(
« no previous file with comments | « extensions/renderer/api_event_handler.h ('k') | extensions/renderer/api_event_handler_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698