Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(35)

Issue 2901213008: Make DocumentMarkerController::Add[Spelling/Grammar]Marker() take EphemeralRange (Closed)

Created:
3 years, 7 months ago by rlanday
Modified:
3 years, 6 months ago
Reviewers:
tkent, yosin_UTC9, Xiaocheng
CC:
blink-reviews, chromium-reviews, groby+blinkspell_chromium.org, kinuko+watch, timvolodine, Xiaocheng
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Make DocumentMarkerController::Add[Spelling/Grammar]Marker() take EphemeralRange Currently DocumentMarkerController::AddSpellingMarker() and AddGrammarMarker() take two Positions (start and end). This CL changes them to instead take an EphemeralRange for consistency with AddTextMatchMarker() and AddCompositionMarker(). BUG=707867 Review-Url: https://codereview.chromium.org/2901213008 Cr-Commit-Position: refs/heads/master@{#475672} Committed: https://chromium.googlesource.com/chromium/src/+/68bd4c5b8ab7bb2d11adc31754197433825bf1da

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -38 lines) Patch
M third_party/WebKit/Source/core/editing/markers/DocumentMarkerController.h View 2 chunks +3 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/core/editing/markers/DocumentMarkerController.cpp View 1 chunk +7 lines, -10 lines 1 comment Download
M third_party/WebKit/Source/core/editing/markers/DocumentMarkerControllerTest.cpp View 2 chunks +2 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/editing/spellcheck/SpellChecker.cpp View 2 chunks +3 lines, -7 lines 0 comments Download
M third_party/WebKit/Source/core/testing/Internals.cpp View 1 chunk +4 lines, -7 lines 0 comments Download
M third_party/WebKit/Source/web/tests/WebFrameTest.cpp View 1 chunk +2 lines, -4 lines 0 comments Download

Messages

Total messages: 15 (10 generated)
rlanday
3 years, 7 months ago (2017-05-26 20:24:40 UTC) #5
yosin_UTC9
lgtm +tkent@ for core/testing and web/tests https://codereview.chromium.org/2901213008/diff/1/third_party/WebKit/Source/core/editing/markers/DocumentMarkerController.cpp File third_party/WebKit/Source/core/editing/markers/DocumentMarkerController.cpp (right): https://codereview.chromium.org/2901213008/diff/1/third_party/WebKit/Source/core/editing/markers/DocumentMarkerController.cpp#newcode143 third_party/WebKit/Source/core/editing/markers/DocumentMarkerController.cpp:143: for (TextIterator marked_text(range.StartPosition(), ...
3 years, 6 months ago (2017-05-29 04:55:33 UTC) #9
tkent
lgtm
3 years, 6 months ago (2017-05-29 04:59:28 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2901213008/1
3 years, 6 months ago (2017-05-30 18:30:10 UTC) #12
commit-bot: I haz the power
3 years, 6 months ago (2017-05-30 21:06:19 UTC) #15
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/68bd4c5b8ab7bb2d11adc3175419...

Powered by Google App Engine
This is Rietveld 408576698