third_party/WebKit/Source/core/editing/markers/DocumentMarkerControllerTest.cpp - Issue 2901213008: Make DocumentMarkerController::Add[Spelling/Grammar]Marker() take EphemeralRange

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/editing/markers/DocumentMarkerControllerTest.cpp

Issue 2901213008: Make DocumentMarkerController::Add[Spelling/Grammar]Marker() take EphemeralRange (Closed)

Patch Set: Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/core/editing/markers/DocumentMarkerController.cpp ('K') | « third_party/WebKit/Source/core/editing/markers/DocumentMarkerController.cpp ('k') | third_party/WebKit/Source/core/editing/spellcheck/SpellChecker.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/editing/markers/DocumentMarkerControllerTest.cpp

diff --git a/third_party/WebKit/Source/core/editing/markers/DocumentMarkerControllerTest.cpp b/third_party/WebKit/Source/core/editing/markers/DocumentMarkerControllerTest.cpp

index 0e7d5787e1c3e8d28e454f2bcd521a96a2e704ea..bde1c9d6d5c7224655f058dde00dbcb19d401064 100644

--- a/third_party/WebKit/Source/core/editing/markers/DocumentMarkerControllerTest.cpp

+++ b/third_party/WebKit/Source/core/editing/markers/DocumentMarkerControllerTest.cpp

@@ -72,8 +72,7 @@ void DocumentMarkerControllerTest::MarkNodeContents(Node* node) {

// DocumentMarkerControllerTest::addMarker(), needs them.

GetDocument().UpdateStyleAndLayout();

auto range = EphemeralRange::RangeOfContents(*node);

- MarkerController().AddSpellingMarker(range.StartPosition(),

- range.EndPosition());

+ MarkerController().AddSpellingMarker(range);

}

void DocumentMarkerControllerTest::MarkNodeContentsTextMatch(Node* node) {

@@ -316,8 +315,7 @@ TEST_F(DocumentMarkerControllerTest, RemoveSpellingMarkersUnderWords) {

// Add a spelling marker and a text match marker to "foo".

const EphemeralRange marker_range(Position(text, 0), Position(text, 3));

- MarkerController().AddSpellingMarker(marker_range.StartPosition(),

- marker_range.EndPosition());

+ MarkerController().AddSpellingMarker(marker_range);

MarkerController().AddTextMatchMarker(marker_range,

DocumentMarker::MatchStatus::kInactive);