third_party/WebKit/Source/web/tests/WebFrameTest.cpp - Issue 2901213008: Make DocumentMarkerController::Add[Spelling/Grammar]Marker() take EphemeralRange

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/web/tests/WebFrameTest.cpp

Issue 2901213008: Make DocumentMarkerController::Add[Spelling/Grammar]Marker() take EphemeralRange (Closed)

Patch Set: Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/web/tests/WebFrameTest.cpp

diff --git a/third_party/WebKit/Source/web/tests/WebFrameTest.cpp b/third_party/WebKit/Source/web/tests/WebFrameTest.cpp

index 87e8e69a85da4382b4c2a7a70fa3321e54b60364..41da66e15b58452c34c151e1766463c5e1cd2144 100644

--- a/third_party/WebKit/Source/web/tests/WebFrameTest.cpp

+++ b/third_party/WebKit/Source/web/tests/WebFrameTest.cpp

@@ -6881,10 +6881,8 @@ TEST_P(ParameterizedWebFrameTest, SpellcheckResultErasesMarkers) {

EXPECT_FALSE(exception_state.HadException());

auto range = EphemeralRange::RangeOfContents(*element);

- document->Markers().AddSpellingMarker(range.StartPosition(),

- range.EndPosition());

- document->Markers().AddGrammarMarker(range.StartPosition(),

- range.EndPosition());

+ document->Markers().AddSpellingMarker(range);

+ document->Markers().AddGrammarMarker(range);

EXPECT_EQ(2U, document->Markers().Markers().size());

textcheck.KickNoResults();