Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(609)

Unified Diff: third_party/WebKit/Source/core/editing/markers/DocumentMarkerController.h

Issue 2901213008: Make DocumentMarkerController::Add[Spelling/Grammar]Marker() take EphemeralRange (Closed)
Patch Set: Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/editing/markers/DocumentMarkerController.h
diff --git a/third_party/WebKit/Source/core/editing/markers/DocumentMarkerController.h b/third_party/WebKit/Source/core/editing/markers/DocumentMarkerController.h
index 746aeb784f08576412d7ca3ef9c0c80cb269d00d..513af1cee4086c5bcb0305f91b87526d0d67e1f2 100644
--- a/third_party/WebKit/Source/core/editing/markers/DocumentMarkerController.h
+++ b/third_party/WebKit/Source/core/editing/markers/DocumentMarkerController.h
@@ -53,11 +53,9 @@ class CORE_EXPORT DocumentMarkerController final
explicit DocumentMarkerController(Document&);
void Clear();
- void AddSpellingMarker(const Position& start,
- const Position& end,
+ void AddSpellingMarker(const EphemeralRange&,
const String& description = g_empty_string);
- void AddGrammarMarker(const Position& start,
- const Position& end,
+ void AddGrammarMarker(const EphemeralRange&,
const String& description = g_empty_string);
void AddTextMatchMarker(const EphemeralRange&, DocumentMarker::MatchStatus);
void AddCompositionMarker(const EphemeralRange&,
@@ -112,8 +110,7 @@ class CORE_EXPORT DocumentMarkerController final
private:
void AddMarker(Node*, DocumentMarker*);
- void AddSpellCheckMarker(const Position& start,
- const Position& end,
+ void AddSpellCheckMarker(const EphemeralRange&,
DocumentMarker::MarkerType,
const String& description = g_empty_string);

Powered by Google App Engine
This is Rietveld 408576698