Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(133)

Issue 2901203002: Rename VisualViewport properties to match updated spec (Closed)

Created:
3 years, 7 months ago by bokan
Modified:
3 years, 7 months ago
Reviewers:
dtapuska
CC:
chromium-reviews, sof, eae+blinkwatch, blink-reviews-dom_chromium.org, dglazkov+blink, asvitkine+watch_chromium.org, blink-reviews, blink-reviews-frames_chromium.org, rwlbuis
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Rename VisualViewport properties to match updated spec This patch changes names in the API to match the updates to the spec since the initial implementation. Specifically: window.visualViewport -> window.view scrollLeft -> offsetLeft scrollTop -> offsetTop pageX -> pageLeft pageY -> pageTop clientWidth -> width clientHeight -> height Spec: https://wicg.github.io/ViewportAPI/spec.html BUG=595826 Review-Url: https://codereview.chromium.org/2901203002 Cr-Commit-Position: refs/heads/master@{#474484} Committed: https://chromium.googlesource.com/chromium/src/+/fad476c5b04ee86096641a9ed979239b72c11483

Patch Set 1 #

Patch Set 2 : Fixed some more expectations #

Patch Set 3 : Removed changes to VisualViewport type #

Total comments: 4

Patch Set 4 : Make methods const #

Unified diffs Side-by-side diffs Delta from patch set Stats (+167 lines, -173 lines) Patch
M third_party/WebKit/LayoutTests/fast/dom/Window/property-access-on-cached-properties-after-frame-navigated-expected.txt View 1 1 chunk +7 lines, -7 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/dom/Window/property-access-on-cached-properties-after-frame-removed-and-gced-expected.txt View 1 1 chunk +7 lines, -7 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/dom/Window/property-access-on-cached-properties-after-frame-removed-expected.txt View 1 1 chunk +7 lines, -7 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/dom/Window/property-access-on-cached-window-after-frame-navigated-expected.txt View 1 1 chunk +7 lines, -7 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/dom/viewport/read-viewport-size-causes-layout.html View 1 chunk +6 lines, -6 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/dom/viewport/read-viewport-size-in-iframe-causes-layout.html View 1 chunk +4 lines, -4 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/dom/viewport/resize-event-fired-window-resized.html View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/dom/viewport/scroll-resize-events-fired.html View 1 chunk +3 lines, -7 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/dom/viewport/verify-viewport-dimensions.html View 2 chunks +18 lines, -18 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/dom/viewport/viewport-dimensions-exclude-custom-scrollbars.html View 2 chunks +5 lines, -5 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/dom/viewport/viewport-dimensions-exclude-scrollbars.html View 2 chunks +5 lines, -5 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/dom/viewport/viewport-dimensions-iframe.html View 2 chunks +7 lines, -7 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/dom/viewport/viewport-dimensions-under-browser-zoom.html View 4 chunks +10 lines, -10 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/events/pointerevents/pointerevent_touch-action-pinch_zoom_touch.html View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/virtual/service-worker-navigation-preload-disabled/webexposed/global-interface-listing-expected.txt View 1 2 3 chunks +8 lines, -8 lines 0 comments Download
M third_party/WebKit/LayoutTests/webexposed/global-interface-listing-expected.txt View 1 2 3 chunks +8 lines, -8 lines 0 comments Download
M third_party/WebKit/Source/core/dom/Document.cpp View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
D third_party/WebKit/Source/core/frame/DOMVisualViewport.h View 1 2 3 1 chunk +7 lines, -7 lines 0 comments Download
D third_party/WebKit/Source/core/frame/DOMVisualViewport.cpp View 1 2 3 6 chunks +12 lines, -12 lines 0 comments Download
M third_party/WebKit/Source/core/frame/LocalDOMWindow.h View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/frame/LocalDOMWindow.cpp View 1 2 5 chunks +6 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/core/frame/UseCounter.h View 1 2 1 chunk +6 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/core/frame/VisualViewport.h View 1 2 3 2 chunks +6 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/core/frame/VisualViewport.cpp View 1 2 3 6 chunks +7 lines, -9 lines 0 comments Download
D third_party/WebKit/Source/core/frame/VisualViewport.idl View 1 2 1 chunk +6 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/core/frame/Window.idl View 1 2 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/testing/Internals.cpp View 1 chunk +1 line, -1 line 0 comments Download
M tools/metrics/histograms/enums.xml View 1 2 1 chunk +6 lines, -6 lines 0 comments Download

Messages

Total messages: 21 (16 generated)
bokan
ptal.
3 years, 7 months ago (2017-05-24 16:52:07 UTC) #13
dtapuska
lgtm https://codereview.chromium.org/2901203002/diff/40001/third_party/WebKit/Source/core/frame/DOMVisualViewport.h File third_party/WebKit/Source/core/frame/DOMVisualViewport.h (right): https://codereview.chromium.org/2901203002/diff/40001/third_party/WebKit/Source/core/frame/DOMVisualViewport.h#newcode61 third_party/WebKit/Source/core/frame/DOMVisualViewport.h:61: float offsetLeft(); Should these be const? https://codereview.chromium.org/2901203002/diff/40001/third_party/WebKit/Source/core/frame/VisualViewport.h File ...
3 years, 7 months ago (2017-05-24 17:21:41 UTC) #14
bokan
https://codereview.chromium.org/2901203002/diff/40001/third_party/WebKit/Source/core/frame/DOMVisualViewport.h File third_party/WebKit/Source/core/frame/DOMVisualViewport.h (right): https://codereview.chromium.org/2901203002/diff/40001/third_party/WebKit/Source/core/frame/DOMVisualViewport.h#newcode61 third_party/WebKit/Source/core/frame/DOMVisualViewport.h:61: float offsetLeft(); On 2017/05/24 17:21:40, dtapuska wrote: > Should ...
3 years, 7 months ago (2017-05-24 19:17:14 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2901203002/60001
3 years, 7 months ago (2017-05-24 19:18:14 UTC) #18
commit-bot: I haz the power
3 years, 7 months ago (2017-05-25 00:06:18 UTC) #21
Message was sent while issue was closed.
Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/fad476c5b04ee86096641a9ed979...

Powered by Google App Engine
This is Rietveld 408576698