Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(301)

Unified Diff: third_party/WebKit/LayoutTests/fast/dom/viewport/viewport-dimensions-under-browser-zoom.html

Issue 2901203002: Rename VisualViewport properties to match updated spec (Closed)
Patch Set: Make methods const Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/LayoutTests/fast/dom/viewport/viewport-dimensions-under-browser-zoom.html
diff --git a/third_party/WebKit/LayoutTests/fast/dom/viewport/viewport-dimensions-under-browser-zoom.html b/third_party/WebKit/LayoutTests/fast/dom/viewport/viewport-dimensions-under-browser-zoom.html
index 4f057b207789228015b84dd9b24d5f129581258e..9cbafdbd867c17b66eff651b4ce1a04a3e25b4d4 100644
--- a/third_party/WebKit/LayoutTests/fast/dom/viewport/viewport-dimensions-under-browser-zoom.html
+++ b/third_party/WebKit/LayoutTests/fast/dom/viewport/viewport-dimensions-under-browser-zoom.html
@@ -15,7 +15,7 @@
var browserZoomFactor = 1.25;
function viewport() {
- return window.visualViewport;
+ return window.view;
}
var numCallsResize = 0;
@@ -23,7 +23,7 @@
async_test(function(t) {
window.onload = t.step_func(function() {
- window.visualViewport.addEventListener('resize', function(e) {
+ window.view.addEventListener('resize', function(e) {
numCallsResize++;
});
@@ -36,10 +36,10 @@
// Offset visual viewport by 10px.
internals.setVisualViewportOffset(10, 10);
- assert_equals(viewport().scrollTop, 10);
- assert_equals(viewport().scrollLeft, 10);
- assert_equals(viewport().clientWidth, 400);
- assert_equals(viewport().clientHeight, 300);
+ assert_equals(viewport().offsetTop, 10);
+ assert_equals(viewport().offsetLeft, 10);
+ assert_equals(viewport().width, 400);
+ assert_equals(viewport().height, 300);
assert_equals(viewport().scale, 2);
// Apply browser zoom.
@@ -49,10 +49,10 @@
t.step(function() {
assert_equals(numCallsResize, 1, "resize listener called for browzer zoom");
// Visual viewport dimensions should be scaled by the browser zoom factor.
- assert_equals(viewport().scrollTop, 10 / browserZoomFactor);
- assert_equals(viewport().scrollLeft, 10 / browserZoomFactor);
- assert_equals(viewport().clientWidth, 400 / browserZoomFactor);
- assert_equals(viewport().clientHeight, 300 / browserZoomFactor);
+ assert_equals(viewport().offsetTop, 10 / browserZoomFactor);
+ assert_equals(viewport().offsetLeft, 10 / browserZoomFactor);
+ assert_equals(viewport().width, 400 / browserZoomFactor);
+ assert_equals(viewport().height, 300 / browserZoomFactor);
assert_equals(viewport().scale, 2);
t.done();

Powered by Google App Engine
This is Rietveld 408576698