third_party/WebKit/LayoutTests/fast/dom/viewport/viewport-dimensions-exclude-scrollbars.html - Issue 2901203002: Rename VisualViewport properties to match updated spec

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/LayoutTests/fast/dom/viewport/viewport-dimensions-exclude-scrollbars.html

Issue 2901203002: Rename VisualViewport properties to match updated spec (Closed)

Patch Set: Make methods const Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/fast/dom/viewport/viewport-dimensions-exclude-custom-scrollbars.html ('k') | third_party/WebKit/LayoutTests/fast/dom/viewport/viewport-dimensions-iframe.html » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 <!DOCTYPE html>	1 <!DOCTYPE html>

2 <style>	2 <style>

3 body {	3 body {

4 height: 2000px;	4 height: 2000px;

5 width: 2000px;	5 width: 2000px;

6 }	6 }

7 </style>	7 </style>

8 <script src="../../../resources/testharness.js"></script>	8 <script src="../../../resources/testharness.js"></script>

9 <script src="../../../resources/testharnessreport.js"></script>	9 <script src="../../../resources/testharnessreport.js"></script>

10 <script>	10 <script>

11 var browserZoomFactor = 1.25;	11 var browserZoomFactor = 1.25;

12 var pageScaleFactor = 2;	12 var pageScaleFactor = 2;

13 var scrollbarWidthCSSPixels = 15 / pageScaleFactor;	13 var scrollbarWidthCSSPixels = 15 / pageScaleFactor;

14 var scrollbarHeightCSSPixels = 15 / pageScaleFactor;	14 var scrollbarHeightCSSPixels = 15 / pageScaleFactor;

15	15

16 function viewport() {	16 function viewport() {

17 return window.visualViewport;	17 return window.view;

18 }	18 }

19	19

20 async_test(function(t) {	20 async_test(function(t) {

21 window.onload = t.step_func(function() {	21 window.onload = t.step_func(function() {

22 // TODO(ymalik): Remove hook to internals to pinch-zoom here and browser	22 // TODO(ymalik): Remove hook to internals to pinch-zoom here and browser

23 // zoom below. This will be required to upstream to w3c repo.	23 // zoom below. This will be required to upstream to w3c repo.

24 internals.setPageScaleFactor(pageScaleFactor);	24 internals.setPageScaleFactor(pageScaleFactor);

25	25

26 // Verify viewport dimensions exclude scrollbar.	26 // Verify viewport dimensions exclude scrollbar.

27 assert_equals(viewport().clientWidth, 800 / pageScaleFactor - scrollbarWid thCSSPixels);	27 assert_equals(viewport().width, 800 / pageScaleFactor - scrollbarWidthCSSP ixels);

28 assert_equals(viewport().clientHeight, 600 / pageScaleFactor - scrollbarHe ightCSSPixels);	28 assert_equals(viewport().height, 600 / pageScaleFactor - scrollbarHeightCS SPixels);

29	29

30 // Apply browser zoom.	30 // Apply browser zoom.

31 window.internals.setZoomFactor(browserZoomFactor);	31 window.internals.setZoomFactor(browserZoomFactor);

32	32

33 // Verify scrollbar exclusion with browser zoom.	33 // Verify scrollbar exclusion with browser zoom.

34 assert_equals(viewport().clientWidth, 800 / pageScaleFactor / browserZoomF actor - scrollbarWidthCSSPixels);	34 assert_equals(viewport().width, 800 / pageScaleFactor / browserZoomFactor - scrollbarWidthCSSPixels);

35 assert_equals(viewport().clientHeight, 600 / pageScaleFactor / browserZoom Factor - scrollbarHeightCSSPixels);	35 assert_equals(viewport().height, 600 / pageScaleFactor / browserZoomFactor - scrollbarHeightCSSPixels);

36 t.done();	36 t.done();

37 });	37 });

38 }, 'Verify viewport dimensions exclude scrollbars.');	38 }, 'Verify viewport dimensions exclude scrollbars.');

39 </script>	39 </script>

OLD	NEW