Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(288)

Side by Side Diff: third_party/WebKit/Source/core/frame/DOMVisualViewport.h

Issue 2901203002: Rename VisualViewport properties to match updated spec (Closed)
Patch Set: Removed changes to VisualViewport type Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2016 Google Inc. All rights reserved. 2 * Copyright (C) 2016 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 40 matching lines...) Expand 10 before | Expand all | Expand 10 after
51 } 51 }
52 52
53 ~DOMVisualViewport() override; 53 ~DOMVisualViewport() override;
54 54
55 DECLARE_VIRTUAL_TRACE(); 55 DECLARE_VIRTUAL_TRACE();
56 56
57 // EventTarget overrides: 57 // EventTarget overrides:
58 const AtomicString& InterfaceName() const override; 58 const AtomicString& InterfaceName() const override;
59 ExecutionContext* GetExecutionContext() const override; 59 ExecutionContext* GetExecutionContext() const override;
60 60
61 float scrollLeft(); 61 float offsetLeft();
dtapuska 2017/05/24 17:21:40 Should these be const?
bokan 2017/05/24 19:17:14 Done.
62 float scrollTop(); 62 float offsetTop();
63 float pageX(); 63 float pageLeft();
64 float pageY(); 64 float pageTop();
65 double clientWidth(); 65 double width();
66 double clientHeight(); 66 double height();
67 double scale(); 67 double scale();
68 68
69 private: 69 private:
70 explicit DOMVisualViewport(LocalDOMWindow*); 70 explicit DOMVisualViewport(LocalDOMWindow*);
71 71
72 Member<LocalDOMWindow> window_; 72 Member<LocalDOMWindow> window_;
73 }; 73 };
74 74
75 } // namespace blink 75 } // namespace blink
76 76
77 #endif // DOMVisualViewport_h 77 #endif // DOMVisualViewport_h
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698