[objects] Extract DebugInfo and BreakPointInfo to own file

[objects] Extract DebugInfo and BreakPointInfo to own file

BUG=v8:5402
Review-Url: https://codereview.chromium.org/2900713004
Cr-Commit-Position: refs/heads/master@{#45486}
Committed: https://chromium.googlesource.com/v8/v8/+/d74ece41800063f92a3bc02963a0aa83be2288c7

[jgruber, 2017-05-22 12:46:57]

The CQ bit was checked by jgruber@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-22 12:47:07]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[jgruber, 2017-05-22 12:53:38]

The CQ bit was checked by jgruber@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-22 12:53:48]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[jgruber, 2017-05-22 12:54:09]

The CQ bit was checked by jgruber@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-22 12:54:17]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[jgruber, 2017-05-22 13:31:06]

jgruber@chromium.org changed reviewers:
+ marja@chromium.org

[jgruber, 2017-05-22 13:31:07]

https://codereview.chromium.org/2900713004/diff/1/src/objects/breakpoints-info.h
File src/objects/breakpoints-info.h (right):

https://codereview.chromium.org/2900713004/diff/1/src/objects/breakpoints-inf...
src/objects/breakpoints-info.h:19: class BreakPointInfo : public Tuple2 {
I'm planning on adding a BreakPointsInfo class in a follow-up, hence the
filename 'break-points-info' (plural).

[commit-bot: I haz the power, 2017-05-22 13:32:53]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-22 13:32:54]

Dry run: This issue passed the CQ dry run.

[marja, 2017-05-22 13:37:39]

https://codereview.chromium.org/2900713004/diff/40001/src/objects-inl.h
File src/objects-inl.h (right):

https://codereview.chromium.org/2900713004/diff/40001/src/objects-inl.h#newco...
src/objects-inl.h:34: #include "src/objects/break-points-info.h"
You might want to split out the relevant parts of objects-inl.h too, to reduce
the needed build steps when touching break-points-info.h and debug-info.h

https://codereview.chromium.org/2900713004/diff/40001/src/objects/break-point...
File src/objects/break-points-info.h (right):

https://codereview.chromium.org/2900713004/diff/40001/src/objects/break-point...
src/objects/break-points-info.h:19: class BreakPointInfo : public Tuple2 {
This file should be called break-point-info, since the class inside it is
BreakPointInfo.

Actually, it would also be fine to put them both into the same file, wdyt? (We
shouldn't go overboard ie too granular with objects.h splitting either.)

https://codereview.chromium.org/2900713004/diff/40001/src/objects/break-point...
src/objects/break-points-info.h:49: #include "src/objects/object-macros-undef.h"
This should be after the namespace closing

https://codereview.chromium.org/2900713004/diff/40001/src/objects/debug-info.h
File src/objects/debug-info.h (right):

https://codereview.chromium.org/2900713004/diff/40001/src/objects/debug-info....
src/objects/debug-info.h:77: #include "src/objects/object-macros-undef.h"
This should be after closing the namespace

[jgruber, 2017-05-22 13:48:26]

https://codereview.chromium.org/2900713004/diff/40001/src/objects-inl.h
File src/objects-inl.h (right):

https://codereview.chromium.org/2900713004/diff/40001/src/objects-inl.h#newco...
src/objects-inl.h:34: #include "src/objects/break-points-info.h"
On 2017/05/22 13:37:39, marja wrote:
> You might want to split out the relevant parts of objects-inl.h too, to reduce
> the needed build steps when touching break-points-info.h and debug-info.h

Acknowledged, perhaps in a follow-up to avoid duplicate work (I'm planning on
changing much of the implementation).

https://codereview.chromium.org/2900713004/diff/40001/src/objects/break-point...
File src/objects/break-points-info.h (right):

https://codereview.chromium.org/2900713004/diff/40001/src/objects/break-point...
src/objects/break-points-info.h:19: class BreakPointInfo : public Tuple2 {
On 2017/05/22 13:37:39, marja wrote:
> This file should be called break-point-info, since the class inside it is
> BreakPointInfo.
> 
> Actually, it would also be fine to put them both into the same file, wdyt? (We
> shouldn't go overboard ie too granular with objects.h splitting either.)

Ugh, my comment got lost since I uploaded new patch-sets :) See
https://codereview.chromium.org/2900713004/diff/1/src/objects/breakpoints-inf...

https://codereview.chromium.org/2900713004/diff/40001/src/objects/break-point...
src/objects/break-points-info.h:49: #include "src/objects/object-macros-undef.h"
On 2017/05/22 13:37:39, marja wrote:
> This should be after the namespace closing

Will do.

https://codereview.chromium.org/2900713004/diff/40001/src/objects/debug-info.h
File src/objects/debug-info.h (right):

https://codereview.chromium.org/2900713004/diff/40001/src/objects/debug-info....
src/objects/debug-info.h:77: #include "src/objects/object-macros-undef.h"
On 2017/05/22 13:37:39, marja wrote:
> This should be after closing the namespace

Will do.

[jgruber, 2017-05-23 09:04:19]

The CQ bit was checked by jgruber@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-23 09:04:31]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[jgruber, 2017-05-23 09:09:53]

The CQ bit was checked by jgruber@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-23 09:10:00]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[jgruber, 2017-05-23 09:12:03]

PTAL at the current patchset.

There's a remaining dependency in that objects-inl.h still includes
src/objects/debug-objects-inl.h. I'll look into breaking that
in a separate CL.

[jgruber, 2017-05-23 09:45:49]

The CQ bit was checked by jgruber@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-23 09:46:00]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[jgruber, 2017-05-23 09:58:36]

https://codereview.chromium.org/2900713004/diff/100001/src/heap/heap.h
File src/heap/heap.h (right):

https://codereview.chromium.org/2900713004/diff/100001/src/heap/heap.h#newcod...
src/heap/heap.h:341: #define FIXED_ARRAY_ELEMENTS_WRITE_BARRIER(heap, array,
start, length) \
Used in both elements.cc and here.

https://codereview.chromium.org/2900713004/diff/100001/src/objects-debug.cc
File src/objects-debug.cc (right):

https://codereview.chromium.org/2900713004/diff/100001/src/objects-debug.cc#n...
src/objects-debug.cc:1: // Copyright 2012 the V8 project authors. All rights
reserved.
Yup, we now have objects-debug and debug-objects :)

IMHO the src/objects/objects-*.{h,cc} would make this more consistent.

https://codereview.chromium.org/2900713004/diff/100001/src/objects-inl.h
File src/objects-inl.h (right):

https://codereview.chromium.org/2900713004/diff/100001/src/objects-inl.h#newc...
src/objects-inl.h:532: CAST_ACCESSOR(AccessCheckInfo)
Sorted and added all STRUCT types except for DebugInfo.

https://codereview.chromium.org/2900713004/diff/100001/src/objects.cc
File src/objects.cc (right):

https://codereview.chromium.org/2900713004/diff/100001/src/objects.cc#newcode...
src/objects.cc:13417: DebugInfo* SharedFunctionInfo::GetDebugInfo() const {
Moved here to avoid including debug-objects-inl.h in objects-inl.h

https://codereview.chromium.org/2900713004/diff/100001/src/objects/object-mac...
File src/objects/object-macros-undef.h (right):

https://codereview.chromium.org/2900713004/diff/100001/src/objects/object-mac...
src/objects/object-macros-undef.h:61: #undef DECLARE_VERIFIER
Removing this duplicate in the next patchset.

[commit-bot: I haz the power, 2017-05-23 10:31:18]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-23 10:31:19]

Dry run: This issue passed the CQ dry run.

[marja, 2017-05-23 10:38:56]

lgtm w/ comment about CAST_ACCESSORS

https://codereview.chromium.org/2900713004/diff/100001/src/objects-inl.h
File src/objects-inl.h (right):

https://codereview.chromium.org/2900713004/diff/100001/src/objects-inl.h#newc...
src/objects-inl.h:7968: #undef CAST_ACCESSORS
What's this?

https://codereview.chromium.org/2900713004/diff/100001/src/objects/debug-obje...
File src/objects/debug-objects-inl.h (right):

https://codereview.chromium.org/2900713004/diff/100001/src/objects/debug-obje...
src/objects/debug-objects-inl.h:10: #include "src/heap/heap-inl.h"
Unfortunately this ends up pulling in objects-inl.h because heap-inl.h includes
it. But this is fine for an intermediate step (objects-inl.h should become
empty).

[jgruber, 2017-05-23 10:50:32]

The CQ bit was checked by jgruber@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-23 10:50:34]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[jgruber, 2017-05-23 10:50:52]

https://codereview.chromium.org/2900713004/diff/100001/src/objects-inl.h
File src/objects-inl.h (right):

https://codereview.chromium.org/2900713004/diff/100001/src/objects-inl.h#newc...
src/objects-inl.h:7968: #undef CAST_ACCESSORS
On 2017/05/23 10:38:55, marja wrote:
> What's this?

Removed all of these as they're now in object-macros-undef.h

https://codereview.chromium.org/2900713004/diff/100001/src/objects/debug-obje...
File src/objects/debug-objects-inl.h (right):

https://codereview.chromium.org/2900713004/diff/100001/src/objects/debug-obje...
src/objects/debug-objects-inl.h:10: #include "src/heap/heap-inl.h"
On 2017/05/23 10:38:55, marja wrote:
> Unfortunately this ends up pulling in objects-inl.h because heap-inl.h
includes
> it. But this is fine for an intermediate step (objects-inl.h should become
> empty).

Ah, yes :( Acknowledged.

[commit-bot: I haz the power, 2017-05-23 11:21:40]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-23 11:21:41]

Dry run: This issue passed the CQ dry run.

[jgruber, 2017-05-23 11:21:56]

The CQ bit was unchecked by jgruber@chromium.org

[jgruber, 2017-05-23 11:22:01]

The CQ bit was checked by jgruber@chromium.org

[jgruber, 2017-05-23 11:22:02]

The patchset sent to the CQ was uploaded after l-g-t-m from marja@chromium.org
Link to the patchset: https://codereview.chromium.org/2900713004/#ps120001
(title: "Remove undefs from objects-inl.h")

[commit-bot: I haz the power, 2017-05-23 11:22:10]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[jgruber, 2017-05-23 11:23:04]

The CQ bit was unchecked by jgruber@chromium.org

[jgruber, 2017-05-23 11:55:02]

jgruber@chromium.org changed reviewers:
+ clemensh@chromium.org, mlippautz@chromium.org

[jgruber, 2017-05-23 11:55:03]

+clemensh for wasm/
+mlippautz for heap/

PTAL

[Clemens Hammacher, 2017-05-23 11:59:49]

src/wasm LGTM

[Michael Lippautz, 2017-05-23 12:12:57]

heap/ LGTM

[jgruber, 2017-05-23 12:15:04]

The CQ bit was checked by jgruber@chromium.org

[commit-bot: I haz the power, 2017-05-23 12:15:13]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-23 12:17:10]

CQ is committing da patch.

Bot data: {"patchset_id": 120001, "attempt_start_ts": 1495541704778180,
"parent_rev": "9dbafbd5d3eeab36fb8aaa48185bd228658783f6", "commit_rev":
"d74ece41800063f92a3bc02963a0aa83be2288c7"}

[commit-bot: I haz the power, 2017-05-23 12:17:16]

Description was changed from

==========
[objects] Extract DebugInfo and BreakPointInfo to own file

BUG=v8:5402
==========

to

==========
[objects] Extract DebugInfo and BreakPointInfo to own file

BUG=v8:5402

Review-Url: https://codereview.chromium.org/2900713004
Cr-Commit-Position: refs/heads/master@{#45486}
Committed:
https://chromium.googlesource.com/v8/v8/+/d74ece41800063f92a3bc02963a0aa83be2...
==========

[commit-bot: I haz the power, 2017-05-23 12:17:17]

Committed patchset #7 (id:120001) as
https://chromium.googlesource.com/v8/v8/+/d74ece41800063f92a3bc02963a0aa83be2...